Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail cake build on Docker build failure. #319

Merged
merged 1 commit into from
Oct 23, 2022
Merged

Fail cake build on Docker build failure. #319

merged 1 commit into from
Oct 23, 2022

Conversation

frosch95
Copy link
Contributor

Closes #276

The cake build respect the exit code of the started processes and if the exit code differs to zero, the whole build fails.

Respect the exit codes of the processes.
@frosch95 frosch95 temporarily deployed to DOCR registry.digitalocean.com/web-scheduler October 20, 2022 01:33 Inactive
@ElanHasson
Copy link
Member

Thank you @frosch95 for your contribution!

@ElanHasson
Copy link
Member

Looks like something unrelated failed. Will take a look.

@frosch95
Copy link
Contributor Author

@ElanHasson you are welcome.
Looks like Run dotnet nuget push fails with a BadRequest. But no clear hint why.

@ElanHasson
Copy link
Member

I'm guessing something changes with GitHub packages API or a token expired

@ElanHasson
Copy link
Member

Thanks for the contribution @frosch95

@ElanHasson ElanHasson merged commit 5c2b547 into web-scheduler:main Oct 23, 2022
@frosch95 frosch95 deleted the docker_build_exit_codes branch October 23, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker builds don't respect failed subprocess exit codes.
2 participants