Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support string based TenantIds #294

Merged
merged 4 commits into from
Sep 16, 2022
Merged

Support string based TenantIds #294

merged 4 commits into from
Sep 16, 2022

Conversation

ElanHasson
Copy link
Member

@ElanHasson ElanHasson commented Sep 16, 2022 •
edited
Loading

@ElanHasson ElanHasson temporarily deployed to DOCR registry.digitalocean.com/web-scheduler September 16, 2022 18:56 Inactive
@ElanHasson ElanHasson temporarily deployed to GitHub Packages September 16, 2022 18:59 Inactive
@ElanHasson ElanHasson mentioned this pull request Sep 16, 2022
Open
3 tasks
@ElanHasson ElanHasson linked an issue Sep 16, 2022 that may be closed by this pull request
Migrate Guid to string via new property TenantIdString web-scheduler/web-scheduler#271
Closed
joshuaauerbachwatson
joshuaauerbachwatson approved these changes Sep 16, 2022
View reviewed changes
Copy link

@joshuaauerbachwatson joshuaauerbachwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (module limited understanding of the full context)

@ElanHasson ElanHasson self-assigned this Sep 16, 2022
@ElanHasson ElanHasson temporarily deployed to DOCR registry.digitalocean.com/web-scheduler September 16, 2022 20:37 Inactive
@ElanHasson ElanHasson temporarily deployed to GitHub Packages September 16, 2022 20:40 Inactive
@ElanHasson ElanHasson merged commit 36d0097 into main Sep 16, 2022
@ElanHasson ElanHasson deleted the support_tenantidstring branch September 16, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaauerbachwatson joshuaauerbachwatson joshuaauerbachwatson approved these changes

@niks3089 niks3089 Awaiting requested review from niks3089

@piyush0101 piyush0101 Awaiting requested review from piyush0101

@Tejusbharadwaj Tejusbharadwaj Awaiting requested review from Tejusbharadwaj

Assignees

@ElanHasson ElanHasson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Guid to string via new property TenantIdString
2 participants
@ElanHasson @joshuaauerbachwatson