[html/editing/focus] New test for inserting element with autofocus #9440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build PASSEDStarted: 2018-02-08 19:07:39 View more information about this build on: |
domenic
reviewed
May 10, 2019
There was a problem hiding this comment.
Sorry for letting this languish for so long.
This test seems reasonable, however there are a few issues:
- It needs to be rebased on master
- This file is not the best place for it
- It uses the timer task source to delay, which could end up being later than the user interaction task source. I'm not sure how to fix that one.
I'll close this PR and open a new one, putting it in https://github.com/web-platform-tests/wpt/tree/master/html/semantics/forms/autofocus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.