unittests failing because lint test failing #9170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build PASSEDStarted: 2018-01-24 15:35:45 View more information about this build on: |
|
This is failing with: ERROR:lint:css/css-grid/alignment/support/100x100-green.png: The filename support/100x100-green.png is shared by: css/css-flexbox/support/100x100-green.png, css/css-grid/alignment/support/100x100-green.png, css/css-grid/grid-items/support/100x100-green.png (CSS-COLLIDING-SUPPORT-NAME) This seems to be pre-existing. :( |
|
I think you missed a case. |
…ong expectation This got broken by 19c7918
gsnedders
force-pushed
the
lint_breakage
branch
from
ad66d3c
to
6492b30
Compare
jgraham
approved these changes
Jan 24, 2018
|
Sorry, late to the party, but LGTM. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is