Consolidate navigation-timing tests into web-platform-tests #8392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 21, 2017
Build PASSEDStarted: 2017-11-22 14:02:58 View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-781684
branch
2 times, most recently
from
be09de3
to
4ed8eee
Compare
LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/ and LayoutTests/external/wpt/navigation-timing/ have the same origin but have diverged slightly over time. https://chromium-review.googlesource.com/c/chromium/src/+/782419 shows what the interesting differences between the two copies were. metadata_cache in most of the tests were removed when the tests were initially added to web-platform-tests: #181 idlharness.html: It's OK to no longer test an instance of Window, that's being done in the hr-time test: #8388 test_timing_xserver_redirect.html: The bits around pageOrigin were removed in 234a672. That assert was still failing in our own tests, but removing it is OK, using location.hostname is wrong as it doesn't include the port: https://html.spec.whatwg.org/multipage/links.html#dom-hyperlink-hostname Change-Id: Ic5c4151a3e309fee1894c72cd14d159bd314be20 Reviewed-on: https://chromium-review.googlesource.com/781684 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#518626}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-781684
branch
from
4ed8eee
to
f1e3175
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/ and
LayoutTests/external/wpt/navigation-timing/ have the same origin but
have diverged slightly over time.
https://chromium-review.googlesource.com/c/chromium/src/+/782419 shows
what the interesting differences between the two copies were.
metadata_cache in most of the tests were removed when the tests were
initially added to web-platform-tests:
#181
idlharness.html: It's OK to no longer test an instance of Window,
that's being done in the hr-time test:
#8388
test_timing_xserver_redirect.html: The bits around pageOrigin were
removed in 234a672.
That assert was still failing in our own tests, but removing it is OK,
using location.hostname is wrong as it doesn't include the port:
https://html.spec.whatwg.org/multipage/links.html#dom-hyperlink-hostname
Change-Id: Ic5c4151a3e309fee1894c72cd14d159bd314be20
Reviewed-on: https://chromium-review.googlesource.com/781684
Commit-Queue: Philip Jägenstedt foolip@chromium.org
Reviewed-by: Takeshi Yoshino tyoshino@chromium.org
Cr-Commit-Position: refs/heads/master@{#518626}