Additional fetch abort tests #6736

jakearchibald · 2017-08-03T15:47:14Z

This ensures that the readable stream and the fetch promise are rejected with the same error instance.

It also ensures that things thrown by the request constructor happen before rejecting with AbortError.

The above involved abstracting some of the request constructor tests.

w3c-bots · 2017-08-03T16:30:24Z

Build PASSED

Started: 2017-08-14 11:20:23
Finished: 2017-08-14 11:33:46

View more information about this build on:

w3c-bots · 2017-08-03T16:30:25Z

View the complete job log.

Sauce (safari)

Testing web-platform-tests at revision 1438494
Using binary None
Starting tests
All results were stable

All results

5 tests ran

/fetch/api/abort/general-serviceworker.https.html

Subtest	Results	Messages
	OK
`General fetch abort tests in a service worker`	FAIL	`SyntaxError: Unexpected keyword 'function'. Expected ')' to end a compound expression.`

/fetch/api/abort/general-sharedworker.html

Subtest	Results	Messages
	OK
`General fetch abort tests - shared worker`	FAIL	`ReferenceError: Can't find variable: SharedWorker`

/fetch/api/abort/general.any.html

Subtest	Results	Messages
	OK
`Untitled`	FAIL	`SyntaxError: Unexpected identifier 't'. Expected ')' to end an argument list.`

/fetch/api/abort/general.any.worker.html

Subtest	Results	Messages
	OK
`Untitled`	FAIL	`SyntaxError: Unexpected identifier 't'. Expected ')' to end an argument list.`

/fetch/api/request/request-error.html

Subtest	Results	Messages
	OK
`RequestInit's window is not null`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "ReferenceError: Can't find variable: Request" ("ReferenceError") expected object "TypeError" ("TypeError")`
`Input URL is not valid`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "ReferenceError: Can't find variable: Request" ("ReferenceError") expected object "TypeError" ("TypeError")`
`Input URL has credentials`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "ReferenceError: Can't find variable: Request" ("ReferenceError") expected object "TypeError" ("TypeError")`
`RequestInit's mode is navigate`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "ReferenceError: Can't find variable: Request" ("ReferenceError") expected object "TypeError" ("TypeError")`
`RequestInit's referrer is invalid`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "ReferenceError: Can't find variable: Request" ("ReferenceError") expected object "TypeError" ("TypeError")`
`RequestInit's method is invalid`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "ReferenceError: Can't find variable: Request" ("ReferenceError") expected object "TypeError" ("TypeError")`
`RequestInit's method is forbidden`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "ReferenceError: Can't find variable: Request" ("ReferenceError") expected object "TypeError" ("TypeError")`
`RequestInit's mode is no-cors and method is not simple`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "ReferenceError: Can't find variable: Request" ("ReferenceError") expected object "TypeError" ("TypeError")`
`RequestInit's mode is no-cors and integrity is not empty`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "ReferenceError: Can't find variable: Request" ("ReferenceError") expected object "TypeError" ("TypeError")`
`RequestInit's cache mode is only-if-cached and mode is not same-origin`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "ReferenceError: Can't find variable: Request" ("ReferenceError") expected object "TypeError" ("TypeError")`
`Request with cache mode: only-if-cached and fetch mode cors`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "ReferenceError: Can't find variable: Request" ("ReferenceError") expected object "TypeError" ("TypeError")`
`Request with cache mode: only-if-cached and fetch mode no-cors`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "ReferenceError: Can't find variable: Request" ("ReferenceError") expected object "TypeError" ("TypeError")`
`Bad referrerPolicy init parameter value`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "ReferenceError: Can't find variable: Request" ("ReferenceError") expected object "TypeError" ("TypeError")`
`Bad mode init parameter value`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "ReferenceError: Can't find variable: Request" ("ReferenceError") expected object "TypeError" ("TypeError")`
`Bad credentials init parameter value`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "ReferenceError: Can't find variable: Request" ("ReferenceError") expected object "TypeError" ("TypeError")`
`Bad cache init parameter value`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "ReferenceError: Can't find variable: Request" ("ReferenceError") expected object "TypeError" ("TypeError")`
`Bad redirect init parameter value`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "ReferenceError: Can't find variable: Request" ("ReferenceError") expected object "TypeError" ("TypeError")`
`Request should get its content-type from the init request`	FAIL	`Can't find variable: Headers`
`Request should not get its content-type from the init request if init headers are provided`	FAIL	`Can't find variable: Headers`
`Request should get its content-type from the body if none is provided`	FAIL	`Can't find variable: Headers`
`Request should get its content-type from init headers if one is provided`	FAIL	`Can't find variable: Headers`
`Request with cache mode: only-if-cached and fetch mode: same-origin`	FAIL	`Can't find variable: Request`

w3c-bots · 2017-08-03T16:30:26Z

View the complete job log.

Chrome (unstable)

Testing web-platform-tests at revision 1438494
Using binary None
Starting tests

w3c-bots · 2017-08-03T16:30:27Z

View the complete job log.

Sauce (MicrosoftEdge)

Testing web-platform-tests at revision 1438494
Using binary None
Starting tests
All results were stable

All results

5 tests ran

/fetch/api/abort/general-serviceworker.https.html

Subtest	Results	Messages
	OK
`General fetch abort tests in a service worker`	FAIL	`Expected ')'`

/fetch/api/abort/general-sharedworker.html

Subtest	Results	Messages
	OK
`General fetch abort tests - shared worker`	FAIL	`'SharedWorker' is undefined`

/fetch/api/abort/general.any.html

Subtest	Results	Messages
	OK
`Untitled`	FAIL	`Expected ')'`

/fetch/api/abort/general.any.worker.html

Subtest	Results	Messages
	OK
`Untitled`	FAIL	`Expected ')'`

/fetch/api/request/request-error.html

Subtest	Results	Messages
	OK
`RequestInit's window is not null`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "TypeMismatchError" ("TypeMismatchError") expected object "TypeError" ("TypeError")`
`Input URL is not valid`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "TypeMismatchError" ("TypeMismatchError") expected object "TypeError" ("TypeError")`
`Input URL has credentials`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "TypeMismatchError" ("TypeMismatchError") expected object "TypeError" ("TypeError")`
`RequestInit's mode is navigate`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "TypeMismatchError" ("TypeMismatchError") expected object "TypeError" ("TypeError")`
`RequestInit's referrer is invalid`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "TypeMismatchError" ("TypeMismatchError") expected object "TypeError" ("TypeError")`
`RequestInit's method is invalid`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "TypeMismatchError" ("TypeMismatchError") expected object "TypeError" ("TypeError")`
`RequestInit's method is forbidden`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "TypeMismatchError" ("TypeMismatchError") expected object "TypeError" ("TypeError")`
`RequestInit's mode is no-cors and method is not simple`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "TypeMismatchError" ("TypeMismatchError") expected object "TypeError" ("TypeError")`
`RequestInit's mode is no-cors and integrity is not empty`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "TypeMismatchError" ("TypeMismatchError") expected object "TypeError" ("TypeError")`
`RequestInit's cache mode is only-if-cached and mode is not same-origin`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "TypeMismatchError" ("TypeMismatchError") expected object "TypeError" ("TypeError")`
`Request with cache mode: only-if-cached and fetch mode cors`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "TypeMismatchError" ("TypeMismatchError") expected object "TypeError" ("TypeError")`
`Request with cache mode: only-if-cached and fetch mode no-cors`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "TypeMismatchError" ("TypeMismatchError") expected object "TypeError" ("TypeError")`
`Bad referrerPolicy init parameter value`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "TypeMismatchError" ("TypeMismatchError") expected object "TypeError" ("TypeError")`
`Bad mode init parameter value`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "TypeMismatchError" ("TypeMismatchError") expected object "TypeError" ("TypeError")`
`Bad credentials init parameter value`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "TypeMismatchError" ("TypeMismatchError") expected object "TypeError" ("TypeError")`
`Bad cache init parameter value`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "TypeMismatchError" ("TypeMismatchError") expected object "TypeError" ("TypeError")`
`Bad redirect init parameter value`	FAIL	`assert_throws: Expect TypeError exception function "() => new Request(...args)" threw object "TypeMismatchError" ("TypeMismatchError") expected object "TypeError" ("TypeError")`
`Request should get its content-type from the init request`	PASS
`Request should not get its content-type from the init request if init headers are provided`	PASS
`Request should get its content-type from the body if none is provided`	PASS
`Request should get its content-type from init headers if one is provided`	PASS
`Request with cache mode: only-if-cached and fetch mode: same-origin`	FAIL	`TypeMismatchError`

annevk

Instead of fetch/api/abort/general.html and fetch/api/abort/general-worker.html you could have those generated automatically by renaming fetch/api/abort/general.js to fetch/api/abort/general.any.js and using the include syntax detailed at http://web-platform-tests.org/writing-tests/testharness.html (you also need to tweak the shared worker wrapper a bit to load general.any.worker.js).

Looks good overall though.

jakearchibald · 2017-08-04T10:37:31Z

@annevk Thanks! Did not know.

@jgraham I've made some changes to the server to allow .any to work with shared workers and service workers. I've also added the ability to add headers per handler – the service worker won't accepts scripts without a valid script content-type.

annevk · 2017-08-04T10:38:18Z

@jakearchibald oh that looks cool, but please see #4210. We can't change .any like that I think given the existing tests.

jakearchibald · 2017-08-04T10:43:08Z

Doh, I guessed it wouldn't be that easy.

jakearchibald · 2017-08-04T11:16:53Z

@jgraham I've reverting most of my server changes due to #4210, but I've left the headers addition. Could you review?

annevk · 2017-08-04T11:20:45Z

tools/serve/serve.py

@@ -169,6 +174,7 @@ class AnyHtmlHandler(HtmlWrapperHandler):


 class AnyWorkerHandler(WrapperHandler):
+    headers = [('Content-Type', 'application/javascript')]


Should be text/javascript if you want to follow the HTML Standard.

Oh wow, I always thought application/javascript was the preferred type. TIL

jakearchibald · 2017-08-11T10:59:55Z

@jgraham could I get a yay/nay for https://github.com/w3c/web-platform-tests/pull/6736/files#diff-54595105eb1b125bb44120e81a893f4eR40? It's a small change, but needed for service worker tests.

annevk

I assume there's already a test that checks that signal and requestSignal are not equal?

annevk · 2017-08-11T11:35:43Z

fetch/api/abort/general.any.js

+
+  controller.abort();
+
+  assert_true(requestAborted, "Original request signal aborted");


This assert could be inside the clonedRequest.signal event listener. That way we also verify that the order is correct. Should we also check here that for both the .aborted flag is flipped?

If I move the tests within the event callbacks then failure to call those callbacks will look like success. I guess I could push items onto an array to check order too.

You could also use a signal variable that you change in the first listener and that you then assert has changed in the second listener and then change again and then assert it has changed after that listener.

From IRC: As spec'd, the clone's abort event would run before the original's. We need to figure out if this is a problem. If it is, we could change the AbortSignal spec so it has a list of "following signals", which copy things that happen to the original, but it happens after the original's event has despatched.

jakearchibald · 2017-08-11T12:07:49Z

I assume there's already a test that checks that signal and requestSignal are not equal?

Yep!

Ms2ger · 2017-08-11T14:39:21Z

tools/serve/serve.py

@@ -40,6 +40,8 @@ class WrapperHandler(object):

    __meta__ = abc.ABCMeta

+    headers = ()


Please use a list ([]).

Sure thing. Why btw? Just for my own learning, I haven't done python in a while.

A tuple is immutable, a list is mutable (and, argument from purity, tuples are supposed to be things where each field has a predefined meaning, not arbitrary ordered collections).

jgraham · 2017-08-11T14:59:19Z

The serve.py changes look fine.

jakearchibald · 2017-08-14T11:20:33Z

@annevk feedback addressed.

Also filed whatwg/dom#493 to discuss event ordering.

* Making use of .any.js for multi-context tests * Testing that request errors take priority over AbortError * Ensure request stream error is same as promise reject error * Testing request clone behaviour * Adding JS header to .any.worker.js

jakearchibald added 2 commits August 3, 2017 16:43

Avoiding contextualTestName

aa4e7e9

Additional abort tests

58f370a

wpt-pr-bot added the fetch label Aug 3, 2017

wpt-pr-bot requested review from annevk, jdm, mnot and youennf August 3, 2017 15:47

jakearchibald mentioned this pull request Aug 3, 2017

Aborting fetch whatwg/fetch#523

Merged

annevk reviewed Aug 4, 2017

View reviewed changes

Running tests in multiple contexts automatically

125a9dc

wpt-pr-bot added docs infra labels Aug 4, 2017

wpt-pr-bot requested review from dontcallmedom, gsnedders, jgraham, sideshowbarker and zcorpan August 4, 2017 10:36

oops

4552339

Reverting most server changes due to web-platform-tests#4210

08ec024

annevk reviewed Aug 4, 2017

View reviewed changes

jakearchibald added 2 commits August 4, 2017 12:33

Using non-legacy mime type

be2fcd6

Adding request clone tests.

2908f79

annevk reviewed Aug 11, 2017

View reviewed changes

gsnedders removed their request for review August 11, 2017 14:18

Ms2ger reviewed Aug 11, 2017

View reviewed changes

wpt-pr-bot requested a review from gsnedders August 11, 2017 14:39

jakearchibald added 2 commits August 11, 2017 16:01

Using lists

a8e7dde

Addressing feedback

e7878ab

annevk approved these changes Aug 14, 2017

View reviewed changes

jakearchibald merged commit fed14ec into web-platform-tests:master Aug 14, 2017

jakearchibald deleted the fetch-abort branch August 14, 2017 11:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Additional fetch abort tests #6736

Additional fetch abort tests #6736

jakearchibald commented Aug 3, 2017 •

edited by wpt-pr-bot

Loading

w3c-bots commented Aug 3, 2017 •

edited

Loading

w3c-bots commented Aug 3, 2017 •

edited

Loading

w3c-bots commented Aug 3, 2017 •

edited

Loading

w3c-bots commented Aug 3, 2017 •

edited

Loading

annevk left a comment

jakearchibald commented Aug 4, 2017

annevk commented Aug 4, 2017

jakearchibald commented Aug 4, 2017

jakearchibald commented Aug 4, 2017

annevk Aug 4, 2017

jakearchibald Aug 4, 2017

jakearchibald commented Aug 11, 2017

annevk left a comment

annevk Aug 11, 2017

jakearchibald Aug 11, 2017

annevk Aug 11, 2017

jakearchibald Aug 11, 2017

jakearchibald commented Aug 11, 2017

Ms2ger Aug 11, 2017

jakearchibald Aug 11, 2017

jgraham Aug 11, 2017

jakearchibald Aug 11, 2017

jgraham commented Aug 11, 2017

jakearchibald commented Aug 14, 2017

		@@ -169,6 +174,7 @@ class AnyHtmlHandler(HtmlWrapperHandler):


		class AnyWorkerHandler(WrapperHandler):
		headers = [('Content-Type', 'application/javascript')]


		controller.abort();

		assert_true(requestAborted, "Original request signal aborted");

		@@ -40,6 +40,8 @@ class WrapperHandler(object):

		__meta__ = abc.ABCMeta

		headers = ()

Additional fetch abort tests #6736

Additional fetch abort tests #6736

Conversation

jakearchibald commented Aug 3, 2017 • edited by wpt-pr-bot Loading

w3c-bots commented Aug 3, 2017 • edited Loading

Build PASSED

w3c-bots commented Aug 3, 2017 • edited Loading

Sauce (safari)

All results

w3c-bots commented Aug 3, 2017 • edited Loading

Chrome (unstable)

w3c-bots commented Aug 3, 2017 • edited Loading

Sauce (MicrosoftEdge)

All results

annevk left a comment

Choose a reason for hiding this comment

jakearchibald commented Aug 4, 2017

annevk commented Aug 4, 2017

jakearchibald commented Aug 4, 2017

jakearchibald commented Aug 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakearchibald commented Aug 11, 2017

annevk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakearchibald commented Aug 11, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jgraham commented Aug 11, 2017

jakearchibald commented Aug 14, 2017

jakearchibald commented Aug 3, 2017 •

edited by wpt-pr-bot

Loading

w3c-bots commented Aug 3, 2017 •

edited

Loading

w3c-bots commented Aug 3, 2017 •

edited

Loading

w3c-bots commented Aug 3, 2017 •

edited

Loading

w3c-bots commented Aug 3, 2017 •

edited

Loading