Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change webhook URL and add functionality for each job to post to bot #6719

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

bobholt
Copy link
Contributor

@bobholt bobholt commented Aug 2, 2017

This is the PR that will switch from using prbuildbot to the wptdash app. This is dependent on @sideshowbarker completing the GitHub Token setup and updating the vault file in wptdash, but I wanted to get this in front of @jgraham as it includes new check_stability code.

This currently points to the staging server so we can make sure it works before landing. Need to change that before merging.


This change is Reviewable

@jgraham
Copy link
Contributor

jgraham commented Aug 2, 2017

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.


.travis.yml, line 100 at r1 (raw file):

    on_success: never
    on_failure: always
  webhooks: http://pulls-staging.web-platform-tests.org/api/build

Noting that this is a thing that needs to be changed, so we have all data in Reviewable


check_stability.ini, line 10 at r1 (raw file):

# cases.
ignore_changes: resources
results_url: http://pulls-staging.web-platform-tests.org/api/stability

Noting that this is a thing that needs to be changed, so we have all data in Reviewable


Comments from Reviewable

Copy link
Contributor

@sideshowbarker sideshowbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I defer to @jgraham pending resolution of his review comments

@w3c-bots
Copy link

w3c-bots commented Aug 3, 2017

Build PASSED

Started: 2017-08-09 11:42:30
Finished: 2017-08-09 11:57:46

View more information about this build on:

@bobholt
Copy link
Contributor Author

bobholt commented Aug 3, 2017

Almost there. Looks like I need to fix a conditional in the template.

@bobholt
Copy link
Contributor Author

bobholt commented Aug 4, 2017

@jgraham I think this is ready to go pending the following:

  1. Any further code review you'd like to do
  2. Land fix has_unstable check in comment templates pulls.web-platform-tests.org#11
  3. Remove -staging from URLs and webhook

I'll do #3 after 1 and 2 because doing that will cause it to start immediately posting to the production server. You can see it populating http://pulls-staging.web-platform-tests.org/ with pulls (but no build data except for this PR) already.

The other open question is SSL. I don't think it should hold us up since there's nothing protected there. I'm working with the infrastructure people on our side to make getting and renewing that certificate free and painless for all, but probably won't have that until next week.

@bobholt
Copy link
Contributor Author

bobholt commented Aug 8, 2017

@jgraham. I've added web-platform-tests/pulls.web-platform-tests.org#12 for SSL support to the dashboard. Do you have any other review on this PR before I switch it to reference the production servers instead of staging?

@bobholt
Copy link
Contributor Author

bobholt commented Aug 9, 2017

Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.


.travis.yml, line 100 at r1 (raw file):

Previously, jgraham wrote…

Noting that this is a thing that needs to be changed, so we have all data in Reviewable

Done.


check_stability.ini, line 10 at r1 (raw file):

Previously, jgraham wrote…

Noting that this is a thing that needs to be changed, so we have all data in Reviewable

Done.


Comments from Reviewable

@jgraham
Copy link
Contributor

jgraham commented Aug 9, 2017

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@jgraham jgraham merged commit 1e8b87c into web-platform-tests:master Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants