Change parser behavior of <select><select> #49525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes the HTML parser convert nested <select> tags into </select> instead of </select><select> for backwards compatibility with the old parser. This behavior will apply to any nested selects, such as <select><div><select>. This was recommended here: whatwg/html#10557 (comment) This will be tested here: html5lib/html5lib-tests#178 (comment) Change-Id: I7a39901582b96edc10deca8794b9ce117aa08229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6040687 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1391787}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6040687
branch
from
9499b57 to
4af93c5
Compare
wpt-pr-bot
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the HTML parser convert nested <select> tags into
</select> instead of </select><select> for backwards compatibility with
the old parser. This behavior will apply to any nested selects, such as
<select><div><select>.
This was recommended here:
whatwg/html#10557 (comment)
This will be tested here:
html5lib/html5lib-tests#178 (comment)
Change-Id: I7a39901582b96edc10deca8794b9ce117aa08229
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6040687
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1391787}