Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Headers.prototype[Symbol.iterator] test #4524

Merged
merged 1 commit into from
Jan 11, 2017
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Jan 11, 2017

Per feedback in #4523 the original test would never be able to pass.

Per feedback in #4523 the original test would never be able to pass.
@wpt-pr-bot
Copy link
Collaborator

Notifying @jdm and @youennf. (Learn how reviewing works.)

@wpt-stability-bot
Copy link

Firefox

Testing revision 1d212a7bef7e823551932fb6e53accec562dfe45
Starting 10 test iterations
All results were stable

All results

/fetch/api/headers/headers-basic.html
Subtest Results
OK
Create headers with existing headers with custom iterator FAIL
Create headers with existing headers PASS
Check get method PASS
Create headers from no parameter PASS
Create headers from empty object PASS
Create headers with record PASS
Check forEach method FAIL
Check has method PASS
Check values method FAIL
Check append method PASS
Create headers with 1 should throw PASS
Check set method PASS
Check Symbol.iterator method FAIL
Check entries method FAIL
Create headers from undefined parameter PASS
Check delete method PASS
Create headers with null should throw PASS
Check keys method FAIL
Create headers with sequence PASS

@wpt-stability-bot
Copy link

Chrome

Testing revision 1d212a7bef7e823551932fb6e53accec562dfe45
Starting 10 test iterations
All results were stable

All results

/fetch/api/headers/headers-basic.html
Subtest Results
OK
Create headers with existing headers with custom iterator FAIL
Create headers with existing headers PASS
Check get method PASS
Create headers from no parameter PASS
Create headers from empty object PASS
Create headers with record PASS
Check forEach method PASS
Check has method PASS
Check values method FAIL
Check append method PASS
Create headers with 1 should throw PASS
Check set method PASS
Check Symbol.iterator method PASS
Check entries method FAIL
Create headers from undefined parameter FAIL
Check delete method PASS
Create headers with null should throw PASS
Check keys method FAIL
Create headers with sequence PASS

@jdm jdm merged commit ee7ffe3 into master Jan 11, 2017
@annevk annevk deleted the annevk/headers-symbol branch January 12, 2017 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants