Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AccName: comp_labelledby tests #42522

Merged
merged 4 commits into from
Nov 3, 2023
Merged

AccName: comp_labelledby tests #42522

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d409048
self-referencial labelledby + another IDREF
cookiecrook Oct 13, 2023
9bc38cc
recursion tests
cookiecrook Oct 13, 2023
42a22e6
blocking remaining tests on spec ambiguity issue https://github.com/w…
cookiecrook Oct 13, 2023
4803e83
Review feedback from rahimabdi: cross-reference tests in ./comp_label…
cookiecrook Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions accname/name/comp_labelledby.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,36 @@

<p>Tests the <a href="https://w3c.github.io/accname/#comp_labelledby">#comp_labelledby</a> portions of the AccName <em>Name Computation</em> algorithm.</p>
cookiecrook marked this conversation as resolved.
Show resolved Hide resolved

<div role="group" aria-labelledby="h" class="ex" data-expectedlabel="div group label" data-testname="div group explicitly labelledby heading">
<h2 id="h">div group label</h2>
<!--

Some overlap with tests in:
- /accname/name/comp_name_from_content.html
- /accname/name/shadowdom/*

-->
cookiecrook marked this conversation as resolved.
Show resolved Hide resolved

<div role="group" aria-labelledby="h" class="ex" data-expectedlabel="first heading" data-testname="div group explicitly labelledby heading">
<h2 id="h">first heading</h2>
<p>text inside div group</p>
</div>

<div role="group" aria-label="self label" id="g2" aria-labelledby="g2 h2" class="ex" data-expectedlabel="self label + first heading" data-testname="div group explicitly labelledby self and heading">
<h2 id="h2">+ first heading</h2>
<p>text inside div group</p>
</div>

<nav aria-labelledby="s1 s2 s3 s4" class="ex" data-expectedlabel="verify spaces between foreach" data-testname="nav with verified spaces appended between each of IDREFS">
<span id="s1">verify</span><span id="s2">spaces</span><span>FAIL IF INCLUDED</span><span id="s3">between</span><span id="s4">foreach</span>
</nav>

<!--

Todo: test all remaining cases of https://w3c.github.io/accname/#comp_labelledby
BLOCKED on https://github.com/w3c/accname/issues/209

Once that's resolved, it may be worthwhile to add a new ./comp_labelledby_recursion.html file,
so that the implementation diffs rolling in don't penalize this Interop 2024 test.

All remaining cases of https://w3c.github.io/accname/#comp_labelledby
Comment on lines +41 to +46
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewers: Some follow-on work is blocked by w3c/accname#209 so additional tests will come separately in web-platform-tests/interop-accessibility#68

- comp_labelledby_reset
- comp_labelledby_foreach
- comp_labelledby_set_current
Expand Down