Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AccName: additional text node tests #42407

Merged
merged 11 commits into from
Nov 3, 2023
Merged

AccName: additional text node tests #42407

merged 11 commits into from
Nov 3, 2023

Commits on Oct 11, 2023

  1. text node tests for whitespace, etc.

    @cookiecrook
    cookiecrook committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    2209875 View commit details
    Browse the repository at this point in the history

  2. normalize interior whitespace after discussion with accname editors a… 

    …nd other browser accessibility engineers
    @cookiecrook
    cookiecrook committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    a324df1 View commit details
    Browse the repository at this point in the history

  3. m. trailing whitespace lint

    @cookiecrook
    cookiecrook committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    9e28d6e View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. update whitespace normalization to match 'ascii whitespace' as define… 

    …d by HTML and referenced by ARIA/AccName
    @cookiecrook
    cookiecrook committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    9a7f8a9 View commit details
    Browse the repository at this point in the history

  2. m. extraneous comment from local testing

    @cookiecrook
    cookiecrook committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    35f41ee View commit details
    Browse the repository at this point in the history

  3. m. lint

    @cookiecrook
    cookiecrook committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    a9b092b View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    don't normalize/trim the expectation, only the result
    @cookiecrook
    cookiecrook authored Oct 13, 2023
    Configuration menu
    Copy the full SHA
    955df07 View commit details
    Browse the repository at this point in the history

  5. m. typo

    @cookiecrook
    cookiecrook authored Oct 13, 2023
    1 Configuration menu
    Copy the full SHA
    d51d6b1 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Apply suggestions from code review 

    thx jugglinmike

Co-authored-by: jugglinmike <mike@mikepennisi.com>
    @cookiecrook @jugglinmike
    cookiecrook and jugglinmike authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    c8399e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. m. editorial from jugglinmike 

    Co-authored-by: jugglinmike <mike@mikepennisi.com>
    @cookiecrook @jugglinmike
    cookiecrook and jugglinmike authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f1b2ca4 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. review feedback from rahimabdi; add tests using explicit role assignment

    @cookiecrook
    cookiecrook committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    260d5e5 View commit details
    Browse the repository at this point in the history