-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make navigation-api/ tests resilient to starting with extra NavigationHistoryEntries #42232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
8e3ea02
to
165967d
Compare
…nHistoryEntries When WPT are run in-browser or via wptrunner, there may be additional session history entries when the test starts, so the tests shouldn't assume that they start with navigation.entries().length == 1 or navigation.currentEntry.index == 0. This fixes all directories except navigate-event/ and navigation-methods/, which had enough tests to deserve separate treatment. This is a workaround for #33590. Change-Id: Ic60de8ffe247b374ef3a0e0939fc4c1a3427c7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903245 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Reviewed-by: Weizhong Xia <weizhong@google.com> Cr-Commit-Position: refs/heads/main@{#1204873}
165967d
to
bfa7986
Compare
Uh oh! Looks like an error! DetailsClient ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:
This request requires the client to satisfy the following scope expression:
|
Uh oh! Looks like an error! DetailsClient ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:
This request requires the client to satisfy the following scope expression:
|
Looks like @KyleJu @DanielRyanSmith Admin merge? Thanks! (@natechapin FYI: you can rerun the checks by closing and reopening the PR. Apparently it doesn't seem possible to remove the misleading "Re-run checks" button: #39458) |
…nHistoryEntries (web-platform-tests#42232) When WPT are run in-browser or via wptrunner, there may be additional session history entries when the test starts, so the tests shouldn't assume that they start with navigation.entries().length == 1 or navigation.currentEntry.index == 0. This fixes all directories except navigate-event/ and navigation-methods/, which had enough tests to deserve separate treatment. This is a workaround for web-platform-tests#33590. Change-Id: Ic60de8ffe247b374ef3a0e0939fc4c1a3427c7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903245 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Reviewed-by: Weizhong Xia <weizhong@google.com> Cr-Commit-Position: refs/heads/main@{#1204873} Co-authored-by: Nate Chapin <japhet@chromium.org>
…nHistoryEntries (web-platform-tests#42232) When WPT are run in-browser or via wptrunner, there may be additional session history entries when the test starts, so the tests shouldn't assume that they start with navigation.entries().length == 1 or navigation.currentEntry.index == 0. This fixes all directories except navigate-event/ and navigation-methods/, which had enough tests to deserve separate treatment. This is a workaround for web-platform-tests#33590. Change-Id: Ic60de8ffe247b374ef3a0e0939fc4c1a3427c7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903245 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Reviewed-by: Weizhong Xia <weizhong@google.com> Cr-Commit-Position: refs/heads/main@{#1204873} Co-authored-by: Nate Chapin <japhet@chromium.org>
When WPT are run in-browser or via wptrunner, there may be additional
session history entries when the test starts, so the tests shouldn't
assume that they start with navigation.entries().length == 1 or
navigation.currentEntry.index == 0.
This fixes all directories except navigate-event/ and
navigation-methods/, which had enough tests to deserve separate
treatment.
This is a workaround for #33590.
Change-Id: Ic60de8ffe247b374ef3a0e0939fc4c1a3427c7e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903245
Auto-Submit: Nate Chapin <japhet@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Weizhong Xia <weizhong@google.com>
Cr-Commit-Position: refs/heads/main@{#1204873}