Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply changes from code review comments. #41852

Merged

Conversation

markafoltz
Copy link
Member

This PR updates the previous PR #35827 with edits suggested in code review.

  • Updated README.md
  • Removed extra parens around arrow functions
  • Updated test descriptions and titles

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request besides its author. Please reach out on the chat room to get help with this. Thank you!

Copy link
Contributor

@FritzHeiden FritzHeiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Contributor

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (and I didn't spot any other places where similar edits could be made)

@tidoust tidoust merged commit 1c4413c into web-platform-tests:master Sep 18, 2023
19 checks passed
@markafoltz markafoltz deleted the style-fixes-remote-playback branch September 18, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants