URL: setting port to the empty string should null port #4101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewers for this pull request are: @Sebmaster, @domenic, @frewsxcv, @mikewest, @rubys, @sideshowbarker, @smola, @tomalec, @xiaojunwu, and @zcorpan. |
FirefoxTesting revision 2e75d38 |
ChromeTesting revision 2e75d38 |
annevk
added a commit
to whatwg/html
that referenced
this pull request
Oct 28, 2016
Setting it to the empty string should set the underlying port concept to null. See web-platform-tests/wpt#4101 for test changes and whatwg/url#113 for the change to the URL Standard.
zcorpan
approved these changes
Oct 28, 2016
annevk
pushed a commit
to whatwg/url
that referenced
this pull request
Oct 28, 2016
When it's setter is set to the empty string, it should set the underlying URL's port to null. Previously that was a no-op. This matches Firefox. (Chromium sets the port to zero.) Test: web-platform-tests/wpt#4101 Demo: http://software.hixie.ch/utilities/js/live-dom-viewer/saved/4054
zcorpan
pushed a commit
to whatwg/html
that referenced
this pull request
Oct 28, 2016
Setting it to the empty string should set the underlying port concept to null. See web-platform-tests/wpt#4101 for test changes and whatwg/url#113 for the change to the URL Standard.
alice
pushed a commit
to alice/html
that referenced
this pull request
Jan 8, 2019
Setting it to the empty string should set the underlying port concept to null. See web-platform-tests/wpt#4101 for test changes and whatwg/url#113 for the change to the URL Standard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.