We decided to make abort() no-op more

[annevk]

See whatwg/xhr#88 for the discussion that led
to these changes.

[wpt-pr-bot]

Reviewers for this pull request are: @Manishearth, @Ms2ger, @caitp, @emilio, @hallvors, @ibelem, @jdm, @jungkees, @kangxu, @mathiasbynens, @plehegar, and @ronkorving.

[berniegp]

To cover all issues raised in #88, I believe open-during-abort should also be modified by adding this final check:

assert_equals(client.readyState, 1)

Since abort() does not fire a readystatechange event in step 3, the test cannot currently catch an erroneous state change.

Apologies if this is already covered in this PR.

[annevk]

@berniegp since assert_array_equals in that test happens after the abort() call, aren't we good?

[annevk]

Never mind, I see what you mean.

[wpt-stability-bot]

Testing in Firefox
Files changed:

• /home/travis/build/w3c/web-platform-tests/XMLHttpRequest/abort-during-open.js
• /home/travis/build/w3c/web-platform-tests/XMLHttpRequest/abort-event-abort.htm
• /home/travis/build/w3c/web-platform-tests/XMLHttpRequest/open-during-abort.htm
• /home/travis/build/w3c/web-platform-tests/XMLHttpRequest/send-data-unexpected-tostring.htm

All results were stable

All results

Test	Subtest	Results
/XMLHttpRequest/open-during-abort.htm		OK: 10
	XMLHttpRequest: open() during abort()	PASS: 10
/XMLHttpRequest/abort-event-abort.htm		OK: 10
	XMLHttpRequest: The abort() method: do not fire abort event in OPENED state when send() flag is unset.	FAIL: 10
/XMLHttpRequest/send-data-unexpected-tostring.htm		OK: 10
	send() called from data stringification	PASS: 10
	abort() called from data stringification	FAIL: 10
	open() called from data stringification	PASS: 10

[wpt-stability-bot]

Testing in Chrome
Files changed:

• /home/travis/build/w3c/web-platform-tests/XMLHttpRequest/abort-during-open.js
• /home/travis/build/w3c/web-platform-tests/XMLHttpRequest/abort-event-abort.htm
• /home/travis/build/w3c/web-platform-tests/XMLHttpRequest/open-during-abort.htm
• /home/travis/build/w3c/web-platform-tests/XMLHttpRequest/send-data-unexpected-tostring.htm

All results were stable

All results

Test	Subtest	Results
/XMLHttpRequest/open-during-abort.htm		OK: 10
	XMLHttpRequest: open() during abort()	FAIL: 10
/XMLHttpRequest/abort-event-abort.htm		OK: 10
	XMLHttpRequest: The abort() method: do not fire abort event in OPENED state when send() flag is unset.	FAIL: 10
/XMLHttpRequest/send-data-unexpected-tostring.htm		OK: 10
	send() called from data stringification	PASS: 10
	abort() called from data stringification	FAIL: 10
	open() called from data stringification	PASS: 10