Add BFCache WPT for pages with WebSocket/WebTransport/WebRTC #40117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 22, 2023
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4551703
branch
2 times, most recently
from
1953e3d to
8eb88ce
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4551703
branch
from
8eb88ce to
0a36752
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4551703
branch
4 times, most recently
from
e17f1d3 to
2e3152c
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4551703
branch
2 times, most recently
from
c01e393 to
db5d37f
Compare
4 tasks
This CL adds some missing WPT for BFCache interaction with WebSocket, WebTransport and WebRTC. The page should not be BFCached if there is open connection correspondingly. After the connection is closed, the page should be eligible for BFCache again. Bug: 1446619 Change-Id: Id0b70afed08d3b2520767d09513b6a6c56afb744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4551703 Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Mingyu Lei <leimy@chromium.org> Cr-Commit-Position: refs/heads/main@{#1152289}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4551703
branch
from
db5d37f to
fc1f7e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds some missing WPT for BFCache interaction with WebSocket,
WebTransport and WebRTC. The page should not be BFCached if there is
open connection correspondingly. After the connection is closed, the
page should be eligible for BFCache again.
Bug: 1446619
Change-Id: Id0b70afed08d3b2520767d09513b6a6c56afb744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4551703
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Mingyu Lei <leimy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1152289}