Close popover stack when popovertarget attribute changes #39083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 20, 2023
If the popovertarget attribute is changed on an element in a way which breaks the connection keeping multiple popovers open, then this patch will close all open popovers. This was pointed out here: whatwg/html#9048 (comment) Bug: 1307772, 1408546 Change-Id: I0a42260e97b7ef3fde01f416ef090b50994b8c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4354171 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1120013}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4354171
branch
from
96c8c5b to
341d90a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the popovertarget attribute is changed on an element in a way which
breaks the connection keeping multiple popovers open, then this patch
will close all open popovers. This was pointed out here:
whatwg/html#9048 (comment)
Bug: 1307772, 1408546
Change-Id: I0a42260e97b7ef3fde01f416ef090b50994b8c5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4354171
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1120013}