Add test for Chromium animation bug with delay and step-end transition #37937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
birtles,
dbaron,
grorg,
plinss and
tabatkins
dbaron
approved these changes
Jul 6, 2023
| @@ -0,0 +1,12 @@ | |||
| <!doctyle html> | |||
There was a problem hiding this comment.
doctype rather than doctyle (and in the reference too)... unless the test depends on being quirks mode, in which case remove the line!
| </style> | ||
| <p>With a duration of 507ms, the animation does not reach the 100% keyframe (green background). | ||
|
|
||
| <div class="anim" style="animation-duration: 507ms;"></div> |
There was a problem hiding this comment.
It seems like this style attribute in the reference is unneeded.
| @@ -0,0 +1,34 @@ | |||
| <!doctyle html> | |||
| </style> | ||
| <p>With a duration of 507ms, the animation does not reach the 100% keyframe (green background). | ||
|
|
||
| <div class="anim""></div> |
There was a problem hiding this comment.
Only a single double-quote after anim, please, unless it's relevant to the test.
|
|
||
| <div class="anim""></div> | ||
| <script> | ||
| takeScreenshotDelayed(5000) |
There was a problem hiding this comment.
It's a bit unfortunate to have to use such a long delay, but it sounds like this bug is timing sensitive, so if it's hard to find a shorter delay that also shows the bug then this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for Interop 2023 Web Compatibility.