Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM: Test that some event listeners are passive by default #34623

Merged
merged 2 commits into from
Jun 30, 2022
Merged

DOM: Test that some event listeners are passive by default #34623

merged 2 commits into from
Jun 30, 2022

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Jun 28, 2022

Follows whatwg/dom#1087

@zcorpan zcorpan requested a review from domenic June 28, 2022 12:26
@wpt-pr-bot wpt-pr-bot added the dom label Jun 28, 2022
This was referenced Jun 28, 2022
Merged
Merged
@zcorpan
Copy link
Member Author

zcorpan commented Jun 28, 2022

Test results: https://wpt.fyi/results/dom/events/passive-by-default.html?sha=e09aa79d2c&label=pr_head

All tests pass except the mousewheel event tests in Firefox because Firefox doesn't support that event.

domenic
domenic approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. However I wonder if we should also test that passing explicit { passive: false } overrides this default?

dom/events/passive-by-default.html Outdated Show resolved Hide resolved
@zcorpan
Copy link
Member Author

zcorpan commented Jun 29, 2022

@domenic done, also tested {passive: undefined} and {passive: true}

domenic
domenic approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@zcorpan zcorpan merged commit f1c5bcd into master Jun 30, 2022
@zcorpan zcorpan deleted the bocoup/event-listeners-passive-by-default branch June 30, 2022 08:28
zcorpan added a commit to whatwg/dom that referenced this pull request Jun 30, 2022
@zcorpan
Specify default passive for document-level wheel/mousewheel/touchstar…
b294497 
…t/touchmove events

Tests: web-platform-tests/wpt#34623

Fixes #365.
@zcorpan zcorpan mentioned this pull request Jun 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@annevk annevk Awaiting requested review from annevk

@jdm jdm Awaiting requested review from jdm

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@jdm jdm

Labels
dom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zcorpan @domenic @jdm @wpt-pr-bot