Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional CFRG curve tests #34434

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Add additional CFRG curve tests #34434

merged 3 commits into from
Jun 14, 2022

Conversation

panva
Copy link
Contributor

@panva panva commented Jun 14, 2022

This adds additional vectors for https://wicg.github.io/webcrypto-secure-curves/

@twiss
Copy link
Member

twiss commented Jun 14, 2022

The CI is complaining about duplicate test names; I think it's because of this code:

// Algorithm name specifiers are case-insensitive. Generate several
// case variations of a given name.
function allNameVariants(name, slowTest) {
var upCaseName = name.toUpperCase();
var lowCaseName = name.toLowerCase();
var mixedCaseName = upCaseName.substring(0, 1) + lowCaseName.substring(1);
// for slow tests effectively cut the amount of work in third by only
// returning one variation
if (slowTest) return [mixedCaseName];
return [upCaseName, lowCaseName, mixedCaseName];
}

For X25519 and X448, upCaseName and mixedCaseName are the same. Could you change that function to only return unique name variants, maybe?

WebCryptoAPI/util/helpers.js Outdated Show resolved Hide resolved
@twiss twiss merged commit edca84a into web-platform-tests:master Jun 14, 2022
@panva panva deleted the add-more-cfrg branch October 25, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants