Test using location API to navigate to the current hash #32291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
annevk
reviewed
Jan 12, 2022
Comment on lines
+34
to
+35
| // These don't canonicalize to the current value of location.hash; the post-parsing version of | ||
| // "te<st" is "te%3Cst", uppercase. |
| }, `Using location.hash = "${value}" must reset scroll position`); | ||
| } | ||
|
|
||
| for (const value of ["about:srcdoc#te<st", "about:srcdoc#te%3cst", "about:srcdoc#te%3Cst"]) { |
There was a problem hiding this comment.
So this assumes you can navigate to about:srcdoc, but I don't think we have any allowance for that, do we? I think it ends up as a network error currently.
There was a problem hiding this comment.
These iframes start on about:srcdoc (because I used a srcdoc iframe for the test), so this just causes a fragment navigation, which is allowed.
annevk
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/html#7386.
/cc @annevk @cpeterso