URLPattern: Emit {} around custom names followed by a regexp group.
#31882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 3, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3315419
branch
3 times, most recently
from
c030451
to
bc53b22
Compare
This CL fixes another problem case from: whatwg/urlpattern#145 In this case we need to preserve `{ ... }` braces around a named group followed by a group that may be emitted in regexp `( ... )` group. We don't want `{:foo}(.*)` to be changed to `:foo(.*)` since that changes the meaning from two groups to a single group. Bug: 1263673 Change-Id: Ifc073d7bfb10f437180393b34cc3bf3c869d7f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315419 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/main@{#949705}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3315419
branch
from
bc53b22
to
821795c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL fixes another problem case from:
whatwg/urlpattern#145
In this case we need to preserve
{ ... }braces around a named groupfollowed by a group that may be emitted in regexp
( ... )group. Wedon't want
{:foo}(.*)to be changed to:foo(.*)since that changesthe meaning from two groups to a single group.
Bug: 1263673
Change-Id: Ifc073d7bfb10f437180393b34cc3bf3c869d7f68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315419
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/main@{#949705}