[WPT] BFCache: pushState() in BFCache/non-BFCache cases #31083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 4, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3199857
branch
from
06a497c
to
467c548
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3199857
branch
from
467c548
to
4fc1186
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3199857
branch
2 times, most recently
from
d765e2c
to
cf79302
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3199857
branch
from
cf79302
to
eb1d370
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3199857
branch
from
eb1d370
to
b16634c
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3199857
branch
3 times, most recently
from
b3581ea
to
749141f
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3199857
branch
from
749141f
to
6e5f9c4
Compare
When doing history navigation to an entry that's created via pushState, the page should be: - With BFCache: Restored from BFCache. - Without BFCache: Loaded from the URL set by `pushState()`. While this test contradicts the current spec but matches the desired behavior, and the spec will be fixed as part of whatwg/html#6315. Tests pass on Firefox/Safari/Chrome, except for Safari on non-BFCache case (just because WebLock doesn't disable BFCache). Bug: 1107415, 1298336, whatwg/html#6207 Change-Id: I609276fe865fa92409fd7a547777dba222bac36c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199857 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#972799}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3199857
branch
from
6e5f9c4
to
fcd9015
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing history navigation to an entry that's created
via pushState, the page should be:
pushState().While this test contradicts the current spec but matches
the desired behavior, and the spec will be
fixed as part of whatwg/html#6315.
Tests pass on Firefox/Safari/Chrome,
except for Safari on non-BFCache case
(just because WebLock doesn't disable BFCache).
Bug: 1107415, 1298336, whatwg/html#6207
Change-Id: I609276fe865fa92409fd7a547777dba222bac36c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199857
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#972799}