Make canvas filter input a flat dictionary #30068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 18, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3098009
branch
from
e7a549f
to
cabd0ac
Compare
As initially specced, CanvasFilter inputs had a single key that was the
name of the filter:
ctx.filter = new CanvasFilter({gaussianBlur: {stdDeviation: 5}});
As the result of the debate here
(whatwg/html#6763) the interface is changed to
have a "filter" key that names the filter type:
ctx.filter = new CanvasFilter(
{filter: "gaussianBlur", stdDeviation: 5});
Bug: 1169216
Change-Id: If3fdd9185c1f02dd2dece7db0c92aba76f2d97e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3098009
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#916494}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3098009
branch
from
cabd0ac
to
e5b3929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As initially specced, CanvasFilter inputs had a single key that was the
name of the filter:
ctx.filter = new CanvasFilter({gaussianBlur: {stdDeviation: 5}});
As the result of the debate here
(whatwg/html#6763) the interface is changed to
have a "filter" key that names the filter type:
ctx.filter = new CanvasFilter(
{filter: "gaussianBlur", stdDeviation: 5});
Bug: 1169216
Change-Id: If3fdd9185c1f02dd2dece7db0c92aba76f2d97e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3098009
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#916494}