Remove tentative from preserve-3d-flat-grouping-properties-containing-block. #29425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 17, 2021
…-block. This removes the "tentative" indicator from the filename of preserve-3d-flat-grouping-properties-containing-block.tentative.html, since it's testing for a behavior that is in the current spec. The spec edits were made in w3c/csswg-drafts@7555b67 . The current spec says: A computed value of preserve-3d for transform-style establishes both a stacking context and a containing block for all descendants. If the used value is preserve-3d then it also establishes or extends a 3D rendering context. There was no formal CSS Working Group resolution to make the change, but it was discussed in w3c/csswg-drafts#1950 . Bug: 1008483 Change-Id: Ica5fd6b0acb66aec6f5c6f843ba72b7e59c35d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2970878 Auto-Submit: David Baron <dbaron@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#894327}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2970878
branch
from
e1d698c to
87b9213
Compare
foolip
added a commit
to Ecosystem-Infra/wpt-results-analysis
that referenced
this pull request
Sep 7, 2021
These are all removed or renamed: - /css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-*.html in web-platform-tests/wpt#29567 - /css/css-sizing/aspect-ratio/grid-aspect-ratio-013.html in web-platform-tests/wpt#29577 - /css/css-transforms/3d-rendering-context-behavior.tentative.html in web-platform-tests/wpt#29424 - /css/css-transforms/preserve-3d-flat-grouping-properties-containing-block.tentative.html in web-platform-tests/wpt#29425 - /css/css-transforms/scrolalble-*-3d-transform-z.html in web-platform-tests/wpt#30126
stephenmcgruer
pushed a commit
to Ecosystem-Infra/wpt-results-analysis
that referenced
this pull request
Sep 8, 2021
These are all removed or renamed: - /css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-*.html in web-platform-tests/wpt#29567 - /css/css-sizing/aspect-ratio/grid-aspect-ratio-013.html in web-platform-tests/wpt#29577 - /css/css-transforms/3d-rendering-context-behavior.tentative.html in web-platform-tests/wpt#29424 - /css/css-transforms/preserve-3d-flat-grouping-properties-containing-block.tentative.html in web-platform-tests/wpt#29425 - /css/css-transforms/scrolalble-*-3d-transform-z.html in web-platform-tests/wpt#30126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the "tentative" indicator from the filename of
preserve-3d-flat-grouping-properties-containing-block.tentative.html,
since it's testing for a behavior that is in the current spec.
The spec edits were made in
w3c/csswg-drafts@7555b67 .
The current spec says:
A computed value of preserve-3d for transform-style establishes both a
stacking context and a containing block for all descendants. If the
used value is preserve-3d then it also establishes or extends a 3D
rendering context.
There was no formal CSS Working Group resolution to make the change,
but it was discussed in
w3c/csswg-drafts#1950 .
Bug: 1008483
Change-Id: Ica5fd6b0acb66aec6f5c6f843ba72b7e59c35d4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2970878
Auto-Submit: David Baron <dbaron@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#894327}