Fix the wrong directionality of slots #27954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 9, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2744562
branch
from
026195a to
14bb6a2
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2744562
branch
5 times, most recently
from
4e7438b to
0ffc6c6
Compare
After the CL that introduced the cache of the directionality of the element at https://crrev.com/c/2666349, Slots have a wrong directionality, and this CL supplements additionally as follows: - Resolve the directionality and propagate it to descendant if the slot element or it's parent has dir=auto - Propagate the directionality to the assigned nodes if the slot element has a valid dir attribute - Resolve the directionality if the assigned node or its parent have dir=auto - Resolve the directionality when the assigned node is a text node Bug: 1185781 Change-Id: I9c3bba672f3c9580a1c687539cb3215b0f4f2f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2744562 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by: Mason Freed <masonfreed@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#861868}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2744562
branch
from
0ffc6c6 to
32f5b7d
Compare
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the CL that introduced the cache of the directionality of the
element at https://crrev.com/c/2666349, Slots have a wrong
directionality, and this CL supplements additionally as follows:
slot element or it's parent has dir=auto
element has a valid dir attribute
have dir=auto
Bug: 1185781
Change-Id: I9c3bba672f3c9580a1c687539cb3215b0f4f2f66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2744562
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#861868}