[selectors4] Implement :dir pseudo-class #26159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 16, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2460849
branch
3 times, most recently
from
b87cf84 to
d824089
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2460849
branch
3 times, most recently
from
dd22df3 to
b56e9ed
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2460849
branch
6 times, most recently
from
1c91060 to
938fbec
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2460849
branch
3 times, most recently
from
f9e48b6 to
0eab2d8
Compare
This patch adds support for the new ":dir" pseudo-class. The patch is covered by several of tests imported from the web tests including generic tests in addition to the tests from Firefox and apart from some minor changes on current tests to add the new selector. Intent-to-ship thread is available at: https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/p0Wc66rbVOc BUG=576815 Change-Id: I503c6af95d9c5817e3e71b1b2025a5562929f0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460849 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#833712}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2460849
branch
from
0eab2d8 to
f028168
Compare
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for the new ":dir" pseudo-class.
The patch is covered by several of tests imported from the web tests
including generic tests in addition to the tests from Firefox and
apart from some minor changes on current tests to add the new selector.
Intent-to-ship thread is available at:
https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/p0Wc66rbVOc
BUG=576815
Change-Id: I503c6af95d9c5817e3e71b1b2025a5562929f0d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460849
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833712}