File URL reparse tests #25989
Merged
File URL reparse tests #25989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See whatwg/url#549 for context.
wpt-pr-bot
requested review from
annevk,
domenic,
GPHemsley,
mikewest and
TimothyGu
rmisev
added a commit
to rmisev/url
that referenced
this pull request
Oct 5, 2020
This adds the URL is not special condition to the URL serializer's 5.1. step. Fixes: whatwg#549 Tests: web-platform-tests/wpt#25989
3 tasks
annevk
approved these changes
Oct 8, 2020
annevk
pushed a commit
to whatwg/url
that referenced
this pull request
Oct 8, 2020
By ensuring that a file URL's host is never null. Tests: web-platform-tests/wpt#25989. Fixes #549.
watilde
added a commit
to watilde/node
that referenced
this pull request
Oct 16, 2020
Fixes: nodejs#35571 Refs: whatwg/url#550 Refs: web-platform-tests/wpt#25989
3 tasks
watilde
added a commit
to nodejs/node
that referenced
this pull request
Oct 19, 2020
Fixes: #35571 Refs: whatwg/url#550 Refs: web-platform-tests/wpt#25989 PR-URL: #35671 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/url#549 for context.