-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added navigation-timing/nav2_test_redirect_chain_xserver_final_original_origin #25679
Added navigation-timing/nav2_test_redirect_chain_xserver_final_original_origin #25679
Conversation
CC @yoavweiss @npm1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
navigation-timing/nav2_test_redirect_chain_xserver_final_original_origin.html
Outdated
Show resolved
Hide resolved
Question: |
Looking at the deprecated interface, it seems to imply that the redirects should not be set for cross origin redirects (regardless of TAO). But I don't know where the |
It is called from the HTML spec. For navigation timing, The resource timing properties ( |
Ok thanks, does that answer your question @sefeng211 ? I also filed w3c/navigation-timing#157 because it is really hard to find answers in this spec now. |
So er....this test was written based on the deprecated interface, but it should be interpreted based on the current Fetch spec right...Am I misunderstanding something? If so, should I read it as, it returns 0 because the Sorry! I am having a hard time to understand the spec.. |
Ok, so I think the spec is currently following what Resource Timing is doing, which is to set it depending on TAO checks. In particular this test and the spec seem at odds. I filed w3c/navigation-timing#158 to find out the answer, apologies for the mess in this spec! |
Right. something is actually missing in the spec. I'm on it, thanks for capturing it. |
Adds a test that:
web-platform.test/...
www.web-platform.test/...
(cross origin)www.web-platform.test/...
(cross origin)web-platform.test/...
(same as original origin)In this case, because of the cross-origin redirects,
redirectCount
,redirectStart
andredirectEnd
should all be0
.