Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin isolation: rename the getter (but leave an alias) #25052

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Origin isolation: rename the getter (but leave an alias) #25052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions origin-isolation/1-iframe/parent-no-child-bad-subdomain.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import {
insertIframe,
testSameAgentCluster,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

let frameIndex = 0;
Expand All @@ -21,7 +21,7 @@

// Since the header values are bad there should be no isolation
testSameAgentCluster([self, frameIndex], `"${badValue}"`);
testOriginIsolationRestricted(frameIndex, false, `"${badValue}"`);
testGetter(frameIndex, false, `"${badValue}"`);
++frameIndex;
}
</script>
6 changes: 3 additions & 3 deletions origin-isolation/1-iframe/parent-no-child-yes-same.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import {
insertIframe,
testSameAgentCluster,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -20,6 +20,6 @@
// Since they're same-origin, and the parent loaded without isolation, the
// child's request for isolation gets ignored, and both end up site-keyed.
testSameAgentCluster([self, 0]);
testOriginIsolationRestricted(self, false, "parent");
testOriginIsolationRestricted(0, false, "child");
testGetter(self, false, "parent");
testGetter(0, false, "child");
</script>
6 changes: 3 additions & 3 deletions origin-isolation/1-iframe/parent-no-child-yes-subdomain.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import {
insertIframe,
testDifferentAgentClusters,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -21,6 +21,6 @@
// so the parent ends up in the site-keyed agent cluster and the child in the
// origin-keyed one.
testDifferentAgentClusters([self, 0]);
testOriginIsolationRestricted(self, false, "parent");
testOriginIsolationRestricted(0, true, "child");
testGetter(self, false, "parent");
testGetter(0, true, "child");
</script>
6 changes: 3 additions & 3 deletions origin-isolation/1-iframe/parent-no-child-yeswithparams-subdomain.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import {
insertIframe,
testDifferentAgentClusters,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -21,6 +21,6 @@
// so the parent ends up in the site-keyed agent cluster and the child in the
// origin-keyed one.
testDifferentAgentClusters([self, 0]);
testOriginIsolationRestricted(self, false, "parent");
testOriginIsolationRestricted(0, true, "child");
testGetter(self, false, "parent");
testGetter(0, true, "child");
</script>
6 changes: 3 additions & 3 deletions origin-isolation/1-iframe/parent-yes-child-no-same.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import {
insertIframe,
testSameAgentCluster,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -21,6 +21,6 @@
// child's non-request for isolation gets ignored, and both end up origin-keyed.
testSameAgentCluster([self, 0]);

testOriginIsolationRestricted(self, true, "parent");
testOriginIsolationRestricted(0, true, "child");
testGetter(self, true, "parent");
testGetter(0, true, "child");
</script>
6 changes: 3 additions & 3 deletions origin-isolation/1-iframe/parent-yes-child-no-subdomain.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import {
insertIframe,
testDifferentAgentClusters,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -22,6 +22,6 @@
// agent cluster and the child ends up in the site-keyed one.
testDifferentAgentClusters([self, 0]);

testOriginIsolationRestricted(self, true, "parent");
testOriginIsolationRestricted(0, false, "child");
testGetter(self, true, "parent");
testGetter(0, false, "child");
</script>
6 changes: 3 additions & 3 deletions origin-isolation/1-iframe/parent-yes-child-yes-same.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import {
insertIframe,
testSameAgentCluster,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -21,6 +21,6 @@
// same origin-keyed agent cluster.
testSameAgentCluster([self, 0]);

testOriginIsolationRestricted(self, true, "parent");
testOriginIsolationRestricted(0, true, "child");
testGetter(self, true, "parent");
testGetter(0, true, "child");
</script>
6 changes: 3 additions & 3 deletions origin-isolation/1-iframe/parent-yes-child-yes-subdomain.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import {
insertIframe,
testDifferentAgentClusters,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -22,6 +22,6 @@
// origin-keyed agent cluster (the www subdomain's origin).
testDifferentAgentClusters([self, 0]);

testOriginIsolationRestricted(self, true, "parent");
testOriginIsolationRestricted(0, true, "child");
testGetter(self, true, "parent");
testGetter(0, true, "child");
</script>
8 changes: 4 additions & 4 deletions origin-isolation/2-iframes/parent-no-child1-no-subdomain-child2-yes-subdomain.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import {
insertIframe,
testSameAgentCluster,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -30,7 +30,7 @@
testSameAgentCluster([0, 1], "child1 to child2");
testSameAgentCluster([1, 0], "child2 to child1");

testOriginIsolationRestricted(self, false, "parent");
testOriginIsolationRestricted(0, false, "child1");
testOriginIsolationRestricted(1, false, "child2");
testGetter(self, false, "parent");
testGetter(0, false, "child1");
testGetter(1, false, "child2");
</script>
8 changes: 4 additions & 4 deletions ...n-isolation/2-iframes/parent-no-child1-no-subdomain1-child2-yes-subdomain2.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
insertIframe,
testSameAgentCluster,
testDifferentAgentClusters,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -32,7 +32,7 @@
testDifferentAgentClusters([0, 1], "child1 to child2");
testDifferentAgentClusters([1, 0], "child2 to child1");

testOriginIsolationRestricted(self, false, "parent");
testOriginIsolationRestricted(0, false, "child1");
testOriginIsolationRestricted(1, true, "child2");
testGetter(self, false, "parent");
testGetter(0, false, "child1");
testGetter(1, true, "child2");
</script>
8 changes: 4 additions & 4 deletions origin-isolation/2-iframes/parent-no-child1-yes-subdomain-child2-no-port.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
insertIframe,
testSameAgentCluster,
testDifferentAgentClusters,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -31,7 +31,7 @@
testDifferentAgentClusters([0, 1], "child1 to child2");
testDifferentAgentClusters([1, 0], "child2 to child1");

testOriginIsolationRestricted(self, false, "parent");
testOriginIsolationRestricted(0, true, "child1");
testOriginIsolationRestricted(1, false, "child2");
testGetter(self, false, "parent");
testGetter(0, true, "child1");
testGetter(1, false, "child2");
</script>
8 changes: 4 additions & 4 deletions origin-isolation/2-iframes/parent-no-child1-yes-subdomain-child2-no-subdomain.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
insertIframe,
testSameAgentCluster,
testDifferentAgentClusters,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -32,7 +32,7 @@
testSameAgentCluster([0, 1], "child1 to child2");
testSameAgentCluster([1, 0], "child2 to child1");

testOriginIsolationRestricted(self, false, "parent");
testOriginIsolationRestricted(0, true, "child1");
testOriginIsolationRestricted(1, true, "child2");
testGetter(self, false, "parent");
testGetter(0, true, "child1");
testGetter(1, true, "child2");
</script>
8 changes: 4 additions & 4 deletions origin-isolation/2-iframes/parent-yes-child1-no-subdomain-child2-no-subdomain.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
insertIframe,
testSameAgentCluster,
testDifferentAgentClusters,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -32,7 +32,7 @@
testSameAgentCluster([0, 1], "child1 to child2");
testSameAgentCluster([1, 0], "child2 to child1");

testOriginIsolationRestricted(self, true, "parent");
testOriginIsolationRestricted(0, false, "child1");
testOriginIsolationRestricted(1, false, "child2");
testGetter(self, true, "parent");
testGetter(0, false, "child1");
testGetter(1, false, "child2");
</script>
8 changes: 4 additions & 4 deletions ...in-isolation/2-iframes/parent-yes-child1-no-subdomain-child2-no-subdomain2.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
insertIframe,
testSameAgentCluster,
testDifferentAgentClusters,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -32,7 +32,7 @@
testSameAgentCluster([0, 1], "child1 to child2");
testSameAgentCluster([1, 0], "child2 to child1");

testOriginIsolationRestricted(self, true, "parent");
testOriginIsolationRestricted(0, false, "child1");
testOriginIsolationRestricted(1, false, "child2");
testGetter(self, true, "parent");
testGetter(0, false, "child1");
testGetter(1, false, "child2");
</script>
8 changes: 4 additions & 4 deletions ...in-isolation/2-iframes/parent-yes-child1-no-subdomain-child2-yes-subdomain.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
insertIframe,
testSameAgentCluster,
testDifferentAgentClusters,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -32,7 +32,7 @@
testSameAgentCluster([0, 1], "child1 to child2");
testSameAgentCluster([1, 0], "child2 to child1");

testOriginIsolationRestricted(self, true, "parent");
testOriginIsolationRestricted(0, false, "child1");
testOriginIsolationRestricted(1, false, "child2");
testGetter(self, true, "parent");
testGetter(0, false, "child1");
testGetter(1, false, "child2");
</script>
8 changes: 4 additions & 4 deletions ...n-isolation/2-iframes/parent-yes-child1-no-subdomain-child2-yes-subdomain2.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import {
insertIframe,
testDifferentAgentClusters,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -32,7 +32,7 @@
testDifferentAgentClusters([0, 1], "child1 to child2");
testDifferentAgentClusters([1, 0], "child2 to child1");

testOriginIsolationRestricted(self, true, "parent");
testOriginIsolationRestricted(0, false, "child1");
testOriginIsolationRestricted(1, true, "child2");
testGetter(self, true, "parent");
testGetter(0, false, "child1");
testGetter(1, true, "child2");
</script>
8 changes: 4 additions & 4 deletions origin-isolation/2-iframes/parent-yes-child1-yes-subdomain-child2-no-port.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import {
insertIframe,
testDifferentAgentClusters,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -30,7 +30,7 @@
testDifferentAgentClusters([0, 1], "child1 to child2");
testDifferentAgentClusters([1, 0], "child2 to child1");

testOriginIsolationRestricted(self, true, "parent");
testOriginIsolationRestricted(0, true, "child1");
testOriginIsolationRestricted(1, false, "child2");
testGetter(self, true, "parent");
testGetter(0, true, "child1");
testGetter(1, false, "child2");
</script>
8 changes: 4 additions & 4 deletions ...in-isolation/2-iframes/parent-yes-child1-yes-subdomain-child2-no-subdomain.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
insertIframe,
testSameAgentCluster,
testDifferentAgentClusters,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -32,7 +32,7 @@
testSameAgentCluster([0, 1], "child1 to child2");
testSameAgentCluster([1, 0], "child2 to child1");

testOriginIsolationRestricted(self, true, "parent");
testOriginIsolationRestricted(0, true, "child1");
testOriginIsolationRestricted(1, true, "child2");
testGetter(self, true, "parent");
testGetter(0, true, "child1");
testGetter(1, true, "child2");
</script>
8 changes: 4 additions & 4 deletions ...n-isolation/2-iframes/parent-yes-child1-yes-subdomain-child2-yes-subdomain.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
insertIframe,
testSameAgentCluster,
testDifferentAgentClusters,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -33,7 +33,7 @@
testSameAgentCluster([0, 1], "child1 to child2");
testSameAgentCluster([1, 0], "child2 to child1");

testOriginIsolationRestricted(self, true, "parent");
testOriginIsolationRestricted(0, true, "child1");
testOriginIsolationRestricted(1, true, "child2");
testGetter(self, true, "parent");
testGetter(0, true, "child1");
testGetter(1, true, "child2");
</script>
8 changes: 4 additions & 4 deletions ...-isolation/2-iframes/parent-yes-child1-yes-subdomain-child2-yes-subdomain2.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import {
insertIframe,
testDifferentAgentClusters,
testOriginIsolationRestricted
testGetter
} from "../resources/helpers.mjs";

promise_setup(async () => {
Expand All @@ -32,7 +32,7 @@
testDifferentAgentClusters([0, 1], "child1 to child2");
testDifferentAgentClusters([1, 0], "child2 to child1");

testOriginIsolationRestricted(self, true, "parent");
testOriginIsolationRestricted(0, true, "child1");
testOriginIsolationRestricted(1, true, "child2");
testGetter(self, true, "parent");
testGetter(0, true, "child1");
testGetter(1, true, "child2");
</script>
Loading