Support async iterable declarations in idlharness

[MattiasBuelens]

Currently, the idlharness incorrectly interprets async iterable declarations (as used in the Streams spec) as if they were regular iterables. This PR fixes that by adding separate testing logic for such async iterable declarations.

I also added tests for the entries, keys, values and forEach methods of pair iterable declarations, to match the new tests for the methods on asynchronous pair iterables.

Fixes #24174

[MattiasBuelens]

Looks like Chrome is failing some of the new tests for methods of a pair iterable. Specifically, the keys, values and forEach methods of MediaKeyStatusMap have an empty string as their function object name.

Firefox and Safari pass these new tests successfully.

Should I file a bug with Chromium for this? (I'm new to this. 😅)

[stephenmcgruer]

Should I file a bug with Chromium for this? (I'm new to this. 😅)

Yes, please do! https://crbug.com/new , much appreciated :)

[domenic]

LGTM with a potential addition.

Note that this closes #24174, and that you may want to remove some of the tests in https://github.com/web-platform-tests/wpt/blob/master/streams/readable-streams/async-iterator.any.js that become redundant with this, either as part of this PR or as a followup.

[MattiasBuelens]

Yes, please do! https://crbug.com/new , much appreciated :)

Done: Chromium bug #1097814. 🙂

Note that this closes #24174

Oh woops, I should probably have searched through the issues first. 😅 Thanks, I've updated the PR description so it will auto-close that issue.

and that you may want to remove some of the tests in https://github.com/web-platform-tests/wpt/blob/master/streams/readable-streams/async-iterator.any.js that become redundant with this

I think only this test would be duplicated? The other tests are related to the prototype of the async iterator, whereas the tests in this PR are about the prototype of the async iterable interface.

Most notably, the tests in this PR never actually create an async iterator. Perhaps we could add that, so we can also cover this test with the WebIDL harness tests.

[domenic]

I think only this test would be duplicated?

Agreed.

Most notably, the tests in this PR never actually create an async iterator. Perhaps we could add that, so we can also cover this test with the WebIDL harness tests.

Yeah, although it's a bit tricky, since there's no guarantee that an async iterator will always be creatable. You'd probably want to add a factory mechanism similar to what exists for interfaces. Best left as a followup, I think.

[domenic]

I guess this will need admin-merging due to macOS infrastructure problems? @stephenmcgruer and @jgraham are already in this thread, so hopefully they can do that.

[stephenmcgruer]

MacOS failures are non-blocking, this needs Taskcluster to finish. Will keep an eye on that :)

[stephenmcgruer]

Both chrome-dev stability and firefox-nightly stability failed.

Chrome-dev was layout-instability:

67:55.98 INFO ## Unstable results ##
67:55.98 INFO |                  Test                 |                                                       Subtest                                                        |          Results           |                                                                      Messages                                                                     |
67:55.98 INFO |---------------------------------------|----------------------------------------------------------------------------------------------------------------------|----------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------|
67:55.98 INFO | `/layout-instability/idlharness.html` | `idl_test setup`                                                                                                     | **FAIL: 1/10, PASS: 9/10** | `promise_test: Unhandled rejection with value: "Timed out waiting for LayoutShift entry"`                                                         |
67:55.98 INFO | `/layout-instability/idlharness.html` | `LayoutShift must be primary interface of layoutShift`                                                               | **FAIL: 1/10, PASS: 9/10** | `assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: layoutShift is not defined"`            |
67:55.98 INFO | `/layout-instability/idlharness.html` | `Stringification of layoutShift`                                                                                     | **FAIL: 1/10, PASS: 9/10** | `assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: layoutShift is not defined"`            |
67:55.98 INFO | `/layout-instability/idlharness.html` | `LayoutShift interface: layoutShift must inherit property "value" with the proper type`                              | **FAIL: 1/10, PASS: 9/10** | `assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: layoutShift is not defined"`            |
67:55.98 INFO | `/layout-instability/idlharness.html` | `LayoutShift interface: layoutShift must inherit property "hadRecentInput" with the proper type`                     | **FAIL: 1/10, PASS: 9/10** | `assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: layoutShift is not defined"`            |
67:55.98 INFO | `/layout-instability/idlharness.html` | `LayoutShift interface: layoutShift must inherit property "lastInputTime" with the proper type`                      | **FAIL: 1/10, PASS: 9/10** | `assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: layoutShift is not defined"`            |
67:55.98 INFO | `/layout-instability/idlharness.html` | `LayoutShift interface: layoutShift must inherit property "sources" with the proper type`                            | **FAIL: 1/10, PASS: 9/10** | `assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: layoutShift is not defined"`            |
67:55.98 INFO | `/layout-instability/idlharness.html` | `LayoutShift interface: layoutShift must inherit property "toJSON()" with the proper type`                           | **FAIL: 1/10, PASS: 9/10** | `assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: layoutShift is not defined"`            |
67:55.98 INFO | `/layout-instability/idlharness.html` | `LayoutShift interface: default toJSON operation on layoutShift`                                                     | **FAIL: 1/10, PASS: 9/10** | `Cannot read property 'toJSON' of undefined`                                                                                                      |
67:55.98 INFO | `/layout-instability/idlharness.html` | `LayoutShiftAttribution must be primary interface of layoutShiftAttribution`                                         | **FAIL: 1/10, PASS: 9/10** | `assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: layoutShiftAttribution is not defined"` |
67:55.98 INFO | `/layout-instability/idlharness.html` | `Stringification of layoutShiftAttribution`                                                                          | **FAIL: 1/10, PASS: 9/10** | `assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: layoutShiftAttribution is not defined"` |
67:55.98 INFO | `/layout-instability/idlharness.html` | `LayoutShiftAttribution interface: layoutShiftAttribution must inherit property "node" with the proper type`         | **FAIL: 1/10, PASS: 9/10** | `assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: layoutShiftAttribution is not defined"` |
67:55.98 INFO | `/layout-instability/idlharness.html` | `LayoutShiftAttribution interface: layoutShiftAttribution must inherit property "previousRect" with the proper type` | **FAIL: 1/10, PASS: 9/10** | `assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: layoutShiftAttribution is not defined"` |
67:55.98 INFO | `/layout-instability/idlharness.html` | `LayoutShiftAttribution interface: layoutShiftAttribution must inherit property "currentRect" with the proper type`  | **FAIL: 1/10, PASS: 9/10** | `assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: layoutShiftAttribution is not defined"` |
67:55.98 INFO 

Firefox stability check timed out (common if there are lots of tests affected).

The Chrome change looks like pre-existing flake, I would guess, so admin-merging this.