Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for URLSearchParams parsing % #24152

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Add test cases for URLSearchParams parsing % #24152

merged 1 commit into from
Jun 15, 2020

Conversation

ijjk
Copy link
Contributor

@ijjk ijjk commented Jun 15, 2020

This adds test cases from nodejs/node#33892 since it was mentioned it might be good to have these here.

Let me know if there are any changes that need to be made, I tested these locally against Firefox and Chrome and they look to be passing ok

@wpt-pr-bot wpt-pr-bot added the url label Jun 15, 2020
@ijjk ijjk mentioned this pull request Jun 15, 2020
Closed
domenic
domenic approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thank you for contributing back!!

@domenic domenic merged commit c79fe56 into web-platform-tests:master Jun 15, 2020
@ijjk ijjk deleted the add/url-search-params-tests branch June 16, 2020 01:22
@ijjk ijjk mentioned this pull request Jun 18, 2020
Closed
watilde added a commit to watilde/node that referenced this pull request Sep 4, 2020
@watilde
test: update WPT tests of URL for URLSearchParams parsing %
73eb5e1 
Related: web-platform-tests/wpt#24152
Related: nodejs#35013
Fixes: nodejs#33892
@watilde watilde mentioned this pull request Sep 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@annevk annevk Awaiting requested review from annevk

@GPHemsley GPHemsley Awaiting requested review from GPHemsley

@mikewest mikewest Awaiting requested review from mikewest

@TimothyGu TimothyGu Awaiting requested review from TimothyGu

Assignees

@domenic domenic

Labels
url
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijjk @domenic @wpt-pr-bot