-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-text] Update line-break-{normal,strict}-015.xht for ICU 66 line breaking rules #22309
Conversation
…breaking rules ICU 66 says that, in normal and strict mode, there are no line break opportunities between the following code points: - U+30EB and U+3002 - U+3002 and U+2025 - U+2025 and U+2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you!
@litherum I'm wondering about these changes. The resulting layout after your changes seems good, but I am not sure it is a "must" level, and if it's not how to deal with testing. The absence of a break between the pairs of U+2025 that the test was originally testing is mandatory (via css-text-3 having a must statement about it), but the other two, while likely good ideas, aren't quite as strongly supported by the spec.
So, I am wondering if we should replace the current test with two different ones:
This is not just a theoretical exercise: all browsers used to pass the test before this change, now they all fail it, so we lost a regression test on a must statement for the sake of getting a nudge on a should statement. Presumably, UAs that use ICU will soon recover, but not all do. |
That would be fine with me. |
…tonly Automatic update from web-platform-tests [css-text] Following up on #22309 (#22458) As per web-platform-tests/wpt#22309 (comment) -- wpt-commits: 8450219d20cf8e5250f857f91e00cf36acf2faf2 wpt-pr: 22458
…tonly Automatic update from web-platform-tests [css-text] Following up on #22309 (#22458) As per web-platform-tests/wpt#22309 (comment) -- wpt-commits: 8450219d20cf8e5250f857f91e00cf36acf2faf2 wpt-pr: 22458 --HG-- rename : testing/web-platform/tests/css/css-text/line-break/reference/line-break-normal-015-ref.xht => testing/web-platform/tests/css/css-text/line-break/reference/line-break-normal-015b-ref.xht rename : testing/web-platform/tests/css/css-text/line-break/reference/line-break-strict-015-ref.xht => testing/web-platform/tests/css/css-text/line-break/reference/line-break-strict-015b-ref.xht
ICU 66 says that, in
ja@lb=normal
andja@lb=strict
mode, there are no line break opportunities between the following code points: