WebOTP: Cleanup navigator.sms.receive() #22199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 11, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2097041
branch
from
a081e62
to
c1eef4d
Compare
This change removes the previous iteration of WebOTP, SMS Receiver API, which we ran for Origin Trial. This is now being removed in favor of the credential management version, WebOTP API [1]. WebOTP API Explainer: https://github.com/WICG/WebOTP I2E ending in M80: https://groups.google.com/a/chromium.org/d/topic/blink-dev/-bdqHhCyBwM/discussion Bug: 1045526 Change-Id: I1e73bed5018c814770fa34edcf64daafd234a543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097041 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#750226}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2097041
branch
from
c1eef4d
to
7ba1c88
Compare
|
The error is unrelated and a fix has been sent: #22249 ; I'm going to force-merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the previous iteration of WebOTP,
SMS Receiver API, which we ran for Origin Trial.
This is now being removed in favor of the credential
management version, WebOTP API [1].
WebOTP API Explainer: https://github.com/WICG/WebOTP
I2E ending in M80: https://groups.google.com/a/chromium.org/d/topic/blink-dev/-bdqHhCyBwM/discussion
Bug: 1045526
Change-Id: I1e73bed5018c814770fa34edcf64daafd234a543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097041
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750226}