Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load Ahem as a web font in css-shapes tests. #19577

Merged
merged 4 commits into from
Oct 9, 2019
Merged

Load Ahem as a web font in css-shapes tests. #19577

merged 4 commits into from
Oct 9, 2019

Commits on Oct 8, 2019

  1. Inline two tests that used generate_tests previously. 

    Also make font setup/restoration explicit rather than per-subtest.
This allows us to setup Ahem usage, then wait for fonts to load, and
then run all computed tests as a discrete block.

The previous method (which dynamically inserted Ahem prior to a subtest
and removed it immediately after) didn't allow us to wait for the web
fonts to be loaded because the test page would have no Ahem usage
present at the time we waited for the fonts.ready event.
    @LukeZielinski
    LukeZielinski committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    dcb4125 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2019

  1. Go back to using generate_tests rather than inlining, but keep the 

    changes to font setup
    @LukeZielinski
    LukeZielinski committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    88600f8 View commit details
    Browse the repository at this point in the history

  2. Update more css-shapes tests to handle font loading correctly.

    @LukeZielinski
    LukeZielinski committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    5182b7d View commit details
    Browse the repository at this point in the history

  3. Hide ParsingUtils.convertToPx, it's not used by tests anymore.

    @LukeZielinski
    LukeZielinski committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    6030e14 View commit details
    Browse the repository at this point in the history