Fix shadow-dom/focus/focus-selector-delegatesFocus.html for slotted elements #19530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lements As specified in https://html.spec.whatwg.org/multipage/semantics-other.html#element-has-the-focus, an element has focus when itself is in the focus chain or its shadow root contains the focused element. Since the shadow tree does not contain a slotted element, its shadow host should not match :focus pseudo class. Otherwise, the shadow host's tree would end up containing more than one element which match :focus, for example, the shadow host and its direct child which is actually focused.
rniwa
requested review from
annevk,
domenic and
emilio
and removed request for
hayatoito,
kojiishi and
TakayoshiKochi
emilio
approved these changes
Oct 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in https://html.spec.whatwg.org/multipage/semantics-other.html#element-has-the-focus, an element has focus when itself is in the focus chain or its shadow root contains the focused element.
Since the shadow tree does not contain a slotted element, its shadow host should not match :focus pseudo class. Otherwise, the shadow host's tree would end up containing more than one element which match :focus, for example, the shadow host and its direct child which is actually focused.