[GitHub Actions] remove the update-pr-preview job #19456
Conversation
As discovered in #19378, the existing setup isn't compatible with the GitHub Actions read-only tokens for pull requests from forks. Since the location of the staging deployment isn't very discoverable even when it does work, disable the job pending a new setup.
|
What do you think about removing the script and its tests, too? I sometimes have trouble understanding who (if anyone) depends on things in the |
|
Sure. I didn't read the config very carefully and look for what would be left dead code. You probably know exactly which bits it are, can you just push a commit to my branch with those removals? |
|
Sure thing. I don't know if you'd like a third opinion since I'm now a participant, so I'll leave merging to you |
|
We reviewed each other's changes so that's okay. |
…ob (web-platform-tests#19456)" This reverts commit 81b79d7.
…ob (web-platform-tests#19456)" This reverts commit 81b79d7.
|
@jugglinmike FYI, since the code that adds the pull-request-has-preview label was removed in this PR and most likely that won't be used in the new solution, I'll remove that label from the repo entirely. |
As discovered in #19378,
the existing setup isn't compatible with the GitHub Actions read-only tokens
for pull requests from forks.
Since the location of the staging deployment isn't very discoverable even
when it does work, disable the job pending a new setup.