Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure selectors-api tests. #1388

Merged
merged 8 commits into from
Nov 18, 2014
Merged

Restructure selectors-api tests. #1388

merged 8 commits into from
Nov 18, 2014

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Nov 16, 2014

No description provided.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/3179

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@sideshowbarker
Copy link
Contributor

I'm confused. Doesn't this conflict with the changes in PR #48? e.g, cb8af58 In particular, I don't understand why we'd want to have it still testing .find and .findAll instead of .query and .queryAll. But I guess I'll go ahead and keep reviewing it on the assumption that we'll be making the renames later or something.

@sideshowbarker
Copy link
Contributor

I can see the value of splitting out the .matches tests at least. Maybe that's the main point of this PR?…

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 18, 2014

Yeah; I'd like to move those to dom/ without being blocked by the find/query issues.

sideshowbarker added a commit that referenced this pull request Nov 18, 2014
@sideshowbarker
Merge pull request #1388 from Ms2ger/selectors-api-in-place
2561d9f 
Restructure selectors-api tests.
@sideshowbarker sideshowbarker merged commit 2561d9f into web-platform-tests:master Nov 18, 2014
@Ms2ger Ms2ger deleted the selectors-api-in-place branch December 5, 2014 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
selectors-api wg-webapps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ms2ger @hoppipolla-critic-bot @sideshowbarker @tobie