Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Range tests for changes to the detach() method. #133

Merged
merged 1 commit into from
Aug 13, 2013

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Jun 5, 2013

No description provided.

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Aug 6, 2013

@ayg, you might want to review this PR.

@ayg
Copy link
Contributor

ayg commented Aug 6, 2013

I like your approach better than mine. You seem to have missed insertNode and selectNode and surroundContents, though, comparing to mine. Still, looks good to me -- how can I mark it reviewed? I'll throw out my pull request until I can rebase it on this one.

jgraham added a commit that referenced this pull request Aug 13, 2013
Update Range tests for changes to the detach() method.
@jgraham jgraham merged commit 8201969 into web-platform-tests:master Aug 13, 2013
@Ms2ger Ms2ger mentioned this pull request Aug 13, 2013
@Ms2ger Ms2ger deleted the detached-range branch August 30, 2013 19:43
jugglinmike pushed a commit to bocoup/wpt that referenced this pull request Apr 11, 2017
jgraham added a commit that referenced this pull request Apr 21, 2017
csnardi added a commit to csnardi/web-platform-tests that referenced this pull request Apr 26, 2018
dd57b9f0db chore(package): update dev deps
7f99dea07c chore(package): bump version number to 10.2.1
c357d4cb01 Add bug link and remove unnecessary quote tests
cd1f7a95ba Add a comment about not using for (const ...)
39a957721c Tokenise a solitary '/' correctly
4efd252f5e Use "let" instead of "var" in for statement
f940514f36 Add count() function. Use idiomatic string methods.
affdfbdc2b Optimise tokenisation and whitespace skipping
ba00d5d9ec refactor: small syntax changes (web-platform-tests#137)
d5c4fbfdfc chore(CHANGELOG): regenerate
3d009b634a chore(CHANGELOG): regenerate
23bb9bb290 chore(CHANGELOG): regenerate
6db306af62 chore(package): bump version number to 10.2.0
ac7ef088f3 fix: solve conflicts from typing union types
f422f2a6f5 feat: type on union types (web-platform-tests#135)
bde0553b49 feat: add const-type for idlTypes (web-platform-tests#132)
c03cd7e8f3 feat: add dictionary/typedef-type (web-platform-tests#133)
6eb1e7f4db feat: add argument/return type (web-platform-tests#134)
d2cfdfd901 feat: add type: attribute-type on idlTypes (web-platform-tests#131)
1e29dcb71b Auto acquisition for parser result changes (web-platform-tests#130)
154eabfbb1 chore(package): update mocha, expect, bump version
36932debd7 Let error messages include the current definition name (web-platform-tests#129)
664f63b61e chore(package-lock): regenerate
536157bffa chore(package): bump version number to 10.0.0
d5b88179df chore(pacakge): upgrade expect dep
0c103b356e Maintain writer.js (web-platform-tests#122)
e2d4467ea1 remove typeExtAttrs from docs
0226b76587 remove iterator documentation (web-platform-tests#123)
e36ae6bf70 BREAKING CHANGE: remove deprecated iterator operation (web-platform-tests#121)
8e73c4ff4c use for-of on tests
c56a921d9b docs(README): iterables ildType is always array
3f39cb152e chore(CHANGELOG): regenerate
ae0060f859 chore(package): bump version number to 9.0.0
24669ed245 BREAKING CHANGE: consistent array type for iterable.idlType (web-platform-tests#117)
f89b5803c7 Update package-lock.json
f581ac63c3 Add myself to contributors in package.json
420ac52ac5 Revert "chore: drop Node 6 support (web-platform-tests#102)"
1c031ed86e chore(CHANGELOG): regenerate

git-subtree-dir: resources/webidl2
git-subtree-split: dd57b9f0db1adbb5712f9fdd6a4e38533ff4ba4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants