Fetch/XHR/Beacon: test locked/disturbed ReadableStream #12639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
caitp,
domfarolino,
ibelem,
igrigorik,
jdm,
jungkees,
Manishearth,
mathiasbynens,
mnot,
toddreifsteck,
wisniewskit,
youennf and
yutakahirano
igrigorik
reviewed
Aug 23, 2018
There was a problem hiding this comment.
LGTM from this end for the sendBeacon portion. Although, I'd love to get @yutakahirano sanity check too.
yutakahirano
requested changes
Aug 24, 2018
| @@ -0,0 +1,23 @@ | |||
| function assert_beacon(stream) { | |||
There was a problem hiding this comment.
Beacon with streams is never going to work because it's keepalive + ReadableStream which is rejected by another reason.
|
@yutakahirano good point, fixed. |
|
|
||
| function assert_request(input, init) { | ||
| assert_throws(new TypeError(), () => new Request(input, init), "new Request()"); | ||
| assert_throws(new TypeError(), () => fetch(input, init), "fetch()"); |
There was a problem hiding this comment.
Because fetch never throws. Maybe we should make all tests asynchronous.
There was a problem hiding this comment.
Oh my, thanks for spotting that.
|
I think I fixed that too. |
yutakahirano
approved these changes
Aug 24, 2018
annevk
added a commit
to whatwg/fetch
that referenced
this pull request
Aug 28, 2018
This also introduces "safely extract" which mainly serves to make it explicit which extraction operations cannot throw. Tests: web-platform-tests/wpt#12639. Fixes #792.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/fetch#801 for context.