HTML: document.open() and mutation events #10680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
reviewed
Apr 30, 2018
There was a problem hiding this comment.
Giving the unreached_funcs names would help a lot here. Firefox says "reaches unreachable code" on http://w3c-test.org/submissions/10680/html/dom/dynamic-markup-insertion/opening-the-input-stream/mutation-events.window.html
Edge and Chrome pass at least.
|
Interesting, it does not for me. Are you using Nightly? |
domenic
approved these changes
Apr 30, 2018
|
Once we start fixing whatwg/dom#640 I'll add more detailed asserts since until then we don't really have a browser that needs them. (And it's a bit of a hassle to update, wait around for the bots to finish, and then merge.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/html#3598.