Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No cross-registrable-domain host is available for testing. #2669

Closed
mikewest opened this issue Mar 14, 2016 · 37 comments
Closed

No cross-registrable-domain host is available for testing. #2669

mikewest opened this issue Mar 14, 2016 · 37 comments

Comments

@mikewest
Copy link
Member

Would it be possible to add a cross-registrable-domain origin to WPT? That is, all of the {{domain[*]}} options are rooted in web-platform.test at the moment, which makes it super-tough to test things like https://tools.ietf.org/html/draft-west-first-party-cookies-06. not-web-platform.test would be ideal (along with not-w3c-test.org, of course).

@annevk annevk added the infra label Mar 14, 2017
@annevk
Copy link
Member

annevk commented Mar 14, 2017

This would be good for document.domain and WebAuthN too. @jgraham @plehegar?

@plehegar
Copy link
Member

plehegar commented Apr 7, 2017

@sideshowbarker do you remember what we did for w3c-test.org? Maybe we can get @w3c-test-alt.org?

@sideshowbarker
Copy link
Member

@sideshowbarker do you remember what we did for w3c-test.org? Maybe we can get @w3c-test-alt.org?

Don’t know what we did for w3c-test.org because I don’t recall being directly involved in the registration. Dunno who handled it, but anyway if we can first just agree on what name we want, I’m sure we can get it registered

@annevk
Copy link
Member

annevk commented Apr 10, 2017

I have a slight preference for something a name without "alt", but maybe I'm being overly sensitive. "w3c-test-2.org" and "web-platform-2.test" locally? Would also be good to have syntax to address it in wptserve.

@annevk
Copy link
Member

annevk commented Apr 10, 2017

(We also need this for SharedArrayBuffer.)

@jgraham
Copy link
Contributor

jgraham commented Apr 10, 2017

Sorry, I was planning to do the wptserve side of this and got swamped. I was thinking of web-platform-alternate.test (I don't really like numbers in names), but happy to go ahead with anything people are happy with.

@mikewest
Copy link
Member Author

not-w3c-test.org? tset-c3w.org? I have no strong opinions, as long as it's not the same eTLD+1, and accessible via {{domains[whatever]}}.

@annevk
Copy link
Member

annevk commented Apr 10, 2017

@jgraham I'm happy with that name and also those that @mikewest proposes.

@plehegar
Copy link
Member

I'm requesting not-w3c-test.org to complement w3c-test.org.

@mikewest
Copy link
Member Author

Ping? If y'all roll something out, I'll land some tests using it. :P

@mikewest
Copy link
Member Author

mikewest commented May 9, 2017

Ping?

@plehegar
Copy link
Member

I'm pushing harder. I don't have a better answer within 2 weeks, I'll look at alternatives (ie non-W3C ones).

@mikewest
Copy link
Member Author

Thanks, @plehegar!

That said, the W3C buying a domain is welcome, but it's not actually the most important bit. :)

If we're going to support a separate domain, we need to teach wptserve about another endpoint. That's the work @jgraham mentioned above, and the bit I intended to be pinging above.

@plehegar
Copy link
Member

www.not-w3c-test.org now exists.

@plehegar plehegar removed their assignment May 10, 2017
@bobholt
Copy link
Contributor

bobholt commented May 26, 2017

@mikewest Does the existence of http://www.not-w3c-test.org/ satisfy the original issue? If there is more to be done, can you describe it here or open a new issue (closing this one)?

@jgraham
Copy link
Contributor

jgraham commented May 26, 2017

No, this requires changes in wptrunner and the documentation so that the domain is usable.

@mikewest
Copy link
Member Author

Any update on this? I'd really like to be able to port some cookie tests to WPT.

@gsnedders
Copy link
Member

So, AIUI, we need a further hostname, which needs changes in the config file (as the hostname is configurable) and in wptserve to listen on those, and add it to the list (lists?) of known host names in wptrunner.

@gsnedders
Copy link
Member

The wptrunner changes should probably try and avoid making #6556 worse.

@foolip
Copy link
Member

foolip commented Oct 4, 2017

Given that this seems to be blocking @mikewest from sharing tests for features in Chromium, I'll call this priority:roadmap so that we don't lose track of it. @gsnedders, is this a 1-day effort? If so, could you treat it as a P3 for this quarter?

@gsnedders
Copy link
Member

@foolip doing it properly is probably a couple of days work, given the technical debt we already have around the hostname stuff.

@foolip
Copy link
Member

foolip commented Oct 9, 2017

Hmm, OK. I guess I'll leave the roadmap label for now, but if someone tries to work on this and fails, maybe we should downgrade to backlog in favor of cleaning up that technical debt.

@gsnedders
Copy link
Member

So, status update:

#8614 is taking more time than I expected, but I think is now basically done. I've spent today writing some tests for it, and found one or two other issues around wptrunner. I'll start on this, on top of that branch, tomorrow or Monday; I don't think this will take more than a day or two, so hopefully we get it all landed in January.

@gsnedders
Copy link
Member

So this proved to be much more painful than I expected, and I spent most of February fighting fires.

However, #9258 renamed external_hosthost and hosthost_ip which got rid of the most awkward part, and allowed me to write #10078 quickly this afternoon which means this finally is actually easy (and hopefully like a four-line patch).

gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Mar 24, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Mar 24, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Mar 28, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 2, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 9, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 9, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 9, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 9, 2018
@foolip
Copy link
Member

foolip commented Apr 24, 2018

@gsnedders do you have an update? #10078 is merged, looks like action is now in #10166?

gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 25, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 25, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 25, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 25, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 25, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 30, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 30, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 30, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 30, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 30, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 30, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 30, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 30, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 30, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 30, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests