Skip to content

Commit

Permalink
Fix test cases intended for special URLs
Browse files Browse the repository at this point in the history
Test cases in the setters_tests.json file below comment "Can’t switch
from URL containing username/password/port to file" are intended for
special URLs. But there are two test cases with "gopher" scheme, which
is not special anymore.

Fix these test cases by changing "gopher" to special scheme "https".

Note. Test cases for non-special URLs are below comments "Can’t switch
from special scheme to non-special" and "Can’t switch from non-special
scheme to special".
  • Loading branch information
rmisev authored and domenic committed Aug 14, 2020
1 parent f36b6b4 commit 6c74b7e
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions url/resources/setters_tests.json
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,11 @@
}
},
{
"href": "gopher://example.net:1234",
"href": "https://example.net:1234",
"new_value": "file",
"expected": {
"href": "gopher://example.net:1234",
"protocol": "gopher:"
"href": "https://example.net:1234/",
"protocol": "https:"
}
},
{
Expand All @@ -145,7 +145,7 @@
},
{
"href": "file:///test",
"new_value": "gopher",
"new_value": "https",
"expected": {
"href": "file:///test",
"protocol": "file:"
Expand Down

0 comments on commit 6c74b7e

Please sign in to comment.