Skip to content

Commit

Permalink
[CompositeClipPathAnimations] Make paint rect encompass entire animation
Browse files Browse the repository at this point in the history
Previously, the paint rect for a composited clip path animation would be
based on the size of the clip path at paint time, which meant that a
clip path animation progressing from a smaller to larger keyframe would
be clipped unnecessarily. This change decides the clip area based on the
union of all keyframes, resulting in a rect that encompasses the entire
animation.

Fuzzy diff is added for one test because of rendering code path differences causing a very small diff. See discussion on crbug.com/1249071 for why this is preferred.

Bug: 1248610, 1372489
Change-Id: Ic9f5658166cbe5698b3486fc6f97fc8a4405850c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3928467
Commit-Queue: Claire Chambers <clchambers@microsoft.com>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1059057}
  • Loading branch information
Claire Chambers authored and chromium-wpt-export-bot committed Oct 14, 2022
1 parent cad591f commit 2ee2935
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<!DOCTYPE html>
<html class="reftest-wait">
<meta name=fuzzy content="0-10;0-150">
<link rel="help" href="https://drafts.csswg.org/css-shapes-1/#basic-shape-interpolation">
<link rel="match" href="clip-path-animation-fixed-position-ref.html">
<!--
Expand Down

0 comments on commit 2ee2935

Please sign in to comment.