Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GitHub wpt org admins have admin access to wpt.fyi #4005

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gsnedders
Copy link
Member

This should make it less nebulous as to who is and isn't an admin.

@KyleJu
Copy link
Collaborator

KyleJu commented Sep 18, 2024

I am unsure about this change - WPT.fyi has a few places where only designated admins can use. E.g. admin handlers where we set the UI and server side flags. Also I noticed that wpt-pr-bot is an admin in the wpt org. I am unsure about the bot account having the admin access.

It is not difficult to manually add an admin to the project, when requested. What do you think @past?

@KyleJu
Copy link
Collaborator

KyleJu commented Sep 24, 2024

I am unsure about this change - WPT.fyi has a few places where only designated admins can use. E.g. admin handlers where we set the UI and server side flags. Also I noticed that wpt-pr-bot is an admin in the wpt org. I am unsure about the bot account having the admin access.

It is not difficult to manually add an admin to the project, when requested. What do you think @past?

Had an offline discussion with the team. We all agreed on having a single source of truth for the admin list - either maintaining a list in wpt.fyi Datastore or fetching from the WPT org, not both. If adding the wpt org admins is necessary, what if we add all wpt org admins to the wpt.fyi admin list, but with limited privileges? e.g. access to the admin handler should be limited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants