Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental interop mobile results view #3959

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DanielRyanSmith
Copy link
Contributor

This change pulls mobile results data from the interop-results repo and uses it to display a new mobile results view on the Interop dashboard. Currently, there is no navigable link displayed on the site, but the page can be accessed by adding the mobileView query string param to the interop 2024 page.

Screenshot 2024-08-25 at 5 52 24 PM

@DanielRyanSmith
Copy link
Contributor Author

It looks like the linter is failing due to an issue unrelated to this change.

api/query/cache/index/index.go:210:18: G115: integer overflow conversion uint64 -> int (gosec)
		shardIdx := int(t.testID % numShardsU64)
		               ^
api/query/cache/backfill/backfill.go:120:14: G115: integer overflow conversion uint64 -> int (gosec)
	limit := int(maxBytes/bytesPerRun) / len(shared.GetDefaultProducts())

securego/gosec#1149

@KyleJu
Copy link
Collaborator

KyleJu commented Aug 26, 2024

It looks like the linter is failing due to an issue unrelated to this change.

api/query/cache/index/index.go:210:18: G115: integer overflow conversion uint64 -> int (gosec)
		shardIdx := int(t.testID % numShardsU64)
		               ^
api/query/cache/backfill/backfill.go:120:14: G115: integer overflow conversion uint64 -> int (gosec)
	limit := int(maxBytes/bytesPerRun) / len(shared.GetDefaultProducts())

securego/gosec#1149

I will get to it shortly

@KyleJu
Copy link
Collaborator

KyleJu commented Aug 26, 2024

It looks like the linter is failing due to an issue unrelated to this change.

api/query/cache/index/index.go:210:18: G115: integer overflow conversion uint64 -> int (gosec)
		shardIdx := int(t.testID % numShardsU64)
		               ^
api/query/cache/backfill/backfill.go:120:14: G115: integer overflow conversion uint64 -> int (gosec)
	limit := int(maxBytes/bytesPerRun) / len(shared.GetDefaultProducts())

securego/gosec#1149

I will get to it shortly

Sent out #3968

@DanielRyanSmith
Copy link
Contributor Author

View the staging deployment here: https://2024-08-25-mobile-resu-dot-wptdashboard-staging.uk.r.appspot.com/interop-2024?mobileView

It might be worth changing this view in some way to be even more explicit that these are mobile results and experimental results.

@jgraham
Copy link
Contributor

jgraham commented Sep 10, 2024

I don't have detailed code-level feedback, but:

  • In general I approve the idea of landing something like this in some hidden way (query parameter, flag, etc.)
  • Even so, I think the page needs explicit text explaining that the mobile work remains a WIP and the scores may not reflect the real level of support for a given feature (don't want people to say "look how the mobile web sucks; browsers are X% worse on interop on mobile" if it's just test infra problems)

@past past closed this Sep 17, 2024
@past past reopened this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants