Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #229: broaden the first Safari stable bad runs range #230

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fixes #229: broaden the first Safari stable bad runs range #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bad-ranges.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ const moment = require('moment');
// inclusive start dates and exclusive end dates.

const STABLE_BAD_RANGES = [
// This was some form of Safari outage, undiagnosed but a clear erroneous
// spike in failure rates.
[moment('2019-02-06'), moment('2019-03-04')],
// This was a safaridriver outage, resolved by
// https://github.com/web-platform-tests/wpt/pull/15659
[moment('2019-02-06'), moment('2019-03-09')],
// This was a safaridriver outage, resolved by
// https://github.com/web-platform-tests/wpt/pull/18585
[moment('2019-06-27'), moment('2019-08-23')],
Expand Down
6 changes: 3 additions & 3 deletions test/bad-ranges.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,17 @@ describe('bad-ranges.js', () => {
it('should advance date at beginning of bad range', () => {
const date = moment('2019-02-06');
const adjusted = advanceDateToSkipBadDataIfNecessary(date);
assert.equal(adjusted.format('YYYY-MM-DD'), '2019-03-04');
assert.equal(adjusted.format('YYYY-MM-DD'), '2019-03-09');
});

it('should advance date in middle of bad range', () => {
const date = moment('2019-02-28');
const adjusted = advanceDateToSkipBadDataIfNecessary(date);
assert.equal(adjusted.format('YYYY-MM-DD'), '2019-03-04');
assert.equal(adjusted.format('YYYY-MM-DD'), '2019-03-09');
});

it('should NOT advance date at end of bad range', () => {
const date = moment('2019-03-04');
const date = moment('2019-03-09');
const adjusted = advanceDateToSkipBadDataIfNecessary(date);
assert.equal(date, adjusted);
});
Expand Down
Loading