Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add popover feature #37

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Add popover feature #37

merged 2 commits into from
Jan 31, 2023

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Jan 12, 2023 •
edited
Loading

Added to HTML here:
whatwg/html#8221
whatwg/html#8717

@foolip
Add popover feature
52abeb8 
Added to HTML today :)
@foolip foolip marked this pull request as draft January 13, 2023 05:21
@foolip
Copy link
Collaborator Author

foolip commented Jan 28, 2023

It's landed in the spec again.

@foolip foolip marked this pull request as ready for review January 28, 2023 10:08
@foolip foolip requested a review from ddbeck January 28, 2023 10:36
ddbeck
ddbeck approved these changes Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ddbeck ddbeck merged commit f0f6643 into main Jan 31, 2023
@foolip foolip deleted the popover branch February 1, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foolip @ddbeck