Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid flash of theme appearance in dev mode #878

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

ambar
Copy link
Contributor

@ambar ambar commented Mar 28, 2024

Summary

Split #877

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 2996e9f
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/66057a9e58bb80000872009c
😎 Deploy Preview https://deploy-preview-878--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 88 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ambar ambar changed the title Feat theme 1 fix: avoid flash of theme appearance in dev mode Mar 28, 2024
@sanyuan0704
Copy link
Collaborator

Thank you

@sanyuan0704 sanyuan0704 merged commit 4a0555f into web-infra-dev:main Apr 2, 2024
11 checks passed
@ambar ambar deleted the feat-theme-1 branch April 2, 2024 12:53
@chenjiahan chenjiahan mentioned this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants