Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lazy compilation use persistent cache restart failure #8952

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

jerrykingxyz
Copy link
Contributor

@jerrykingxyz jerrykingxyz commented Jan 7, 2025

Summary

The client field in LazyCompilationProxyModule will contains port info which can not be shared between different compiler.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jan 7, 2025
Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 725e5cb
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/677ce428ed25f10008f7e861
😎 Deploy Preview https://deploy-preview-8952--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jerrykingxyz jerrykingxyz linked an issue Jan 7, 2025 that may be closed by this pull request
@jerrykingxyz jerrykingxyz enabled auto-merge (squash) January 7, 2025 08:30
Copy link

codspeed-hq bot commented Jan 7, 2025

CodSpeed Performance Report

Merging #8952 will not alter performance

Comparing jerry/cache (725e5cb) with main (2cfa879)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@jerrykingxyz jerrykingxyz changed the title fix: persistent cache use lazy compilation restart failure fix: lazy compilation use persistent cache restart failure Jan 7, 2025
@jerrykingxyz jerrykingxyz merged commit c1a29f4 into main Jan 7, 2025
38 checks passed
@jerrykingxyz jerrykingxyz deleted the jerry/cache branch January 7, 2025 08:47
@h-a-n-a h-a-n-a mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: persistent cache: lazyCompilation not work
2 participants